Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the code from bin/dg to distgen/bin.py #46

Open
bkabrda opened this issue Sep 22, 2017 · 1 comment
Open

Move the code from bin/dg to distgen/bin.py #46

bkabrda opened this issue Sep 22, 2017 · 1 comment

Comments

@bkabrda
Copy link
Collaborator

bkabrda commented Sep 22, 2017

We should move code from bin/dg to a file like distgen/bin.py and use setuptools' entrypoint for the dg binary. This would move all functionality to the distgen library, hence it would be importable, more usable and also testable. This change shouldn't break anything for our users.

@praiskup
Copy link
Member

I like the testability POV, +1. I dislike the re-usability POV on bin/dg code because that's (a) something nobody should depend on and thus (b) taking care of the API (==making it a library) would be IMO just wasting of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants