Pass callback to handle routing for DataCatalog #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
sandrahoang686
changed the title
sandrahoang686
requested review from
dzole0311,
vgeorge,
hanbyul-here and
AliceR
dzole0311
approved these changes
Dec 17, 2024
sandrahoang686
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Dec 17, 2024
**Related Ticket:** #1108 **Related PR:** developmentseed/next-veda-ui#25 **v5.11.3-alpha.0** published from this branch ### Description of Changes As part of the greater holistic approach - I think its best to move away from having our library components tightly integrated w/ routing. This is the first iteration to remove **linkProperties**. This PR only worries about removing **linkProps** the **DataCatalog Component**. DataCatalog view no longer has to pass in linkProperties or have to directly worry about routing, we can just pass in a callback now that decides what to do during some action. This is an iterative approach, i've created tickets to remove routing from the other core components. But we can't remove routing directly from the Card component itself easily as GHG uses the card component directly [here](https://github.com/US-GHG-Center/veda-config-ghg/blob/dfe611f27f910bc6428a2b13fe50678710511e68/custom-pages/news-and-events/component.tsx#L5). So that should be its own separate ticket BUT... we are to be redoing the card component for the new instances - where its probably best to rewrite it. As currently its not in an ideal place to scale... so i'll create a placeholder ticket for card component for now but we can probably tackle removing routing when rewriting the card component. cc @vgeorge @hanbyul-here @dzole0311 Follow-up tickets created: * #1325 * #1326 * #1327 ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing - [ ] Validate DataCatalog cards are linking correctly - [ ] Validate selecting cards in DatasetSelectorModal is working as it should
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Available PR templates
Related Ticket: NASA-IMPACT/veda-ui#1108
Related PR: NASA-IMPACT/veda-ui#1310