Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech-debt: add formatter action #29

Open
Zidious opened this issue Sep 14, 2023 · 1 comment
Open

tech-debt: add formatter action #29

Zidious opened this issue Sep 14, 2023 · 1 comment
Labels
tech-debt We have to repay

Comments

@Zidious
Copy link
Contributor

Zidious commented Sep 14, 2023

We have a pre-commit hook for handling formatting changes with prettier. We should also have a formatter as an action in case the developer commits code via suggestion during code review. We can use this action
@Zidious Zidious added the tech-debt We have to repay label Sep 14, 2023
@straker
Copy link
Contributor

straker commented Oct 5, 2023 •
edited
Loading

I don't think we can do this per this comment:

Workflows are not allowed to edit workflows. As result, we need to prevent Prettier from formatting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt We have to repay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@straker @Zidious