Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a root .nycrc file #109

Open
Zidious opened this issue Dec 19, 2023 · 0 comments
Open

Add a root .nycrc file #109

Zidious opened this issue Dec 19, 2023 · 0 comments
Labels
TYPE: automation Work done on ci (github action, circleci, etc) TYPE: tech-debt Ticket is to make previous decisions more sustainable

Comments

@Zidious
Copy link
Contributor

Zidious commented Dec 19, 2023

All of our GHA's have a nyc property within the package json. We can condense all of these to a root .nycrc (https://github.com/istanbuljs/nyc#configuration-files) file that can contains all of the required checks require, example:

  "nyc": {
    "checkCoverage": true,
    "extension": [
      ".ts"
    ],
    "reporter": [
      "text-summary",
      "html"
    ],
    "statements": 100,
    "branches": 100,
    "functions": 100,
    "lines": 100,
    "exclude": [
      "dist",
      "coverage",
      "**/*.test.ts"
    ]
  }

Then we don't need to have a nyc property to any future actions it will just inherit from the root

@Zidious Zidious added TYPE: tech-debt Ticket is to make previous decisions more sustainable TYPE: automation Work done on ci (github action, circleci, etc) labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TYPE: automation Work done on ci (github action, circleci, etc) TYPE: tech-debt Ticket is to make previous decisions more sustainable
Projects
None yet
Development

No branches or pull requests

1 participant