-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forcing release workers by default might not suit every use case #24
Forcing release workers by default might not suit every use case #24
Comments
Hi I have a similar issue. I'm using git-flow to create releases and I need to perform all release workers except Thanks |
I think main issue is that default https://github.com/symplify/monorepo-builder/blob/main/src/Kernel/MonorepoBuilderKernel.php#L20 Then all config found in use |
Thank you for feedback, this makes sense to revert then 👍 Could you send PR? |
It is the same issue on https://github.com/symplify/symplify-kernel package. # src/Kernel/MonorepoBuilderKernel.php
// Always prepend default config files
$configFiles = array_merge(
[
ConsoleColorDiffConfig::FILE_PATH,
__DIR__ . '/../../config/config.php',
],
$configFiles,
); # vendor/symplify/symplify-kernel/src/HttpKernel/AbstractSymplifyKernel.php
// Always prepend default config files
$configFiles = array_merge(
[
SymplifyKernelConfig::FILE_PATH,
],
$configFiles,
); |
…ilder#24 and must be merged along with symplify/monorepo-builder!32
That seems like playing with Symfony magic. |
@TomasVotruba I don't understand what do you mean by
For the moment, configuration order does matter because we cannot override default release workers or excluded folders defined in https://github.com/symplify/monorepo-builder/blob/main/config/config.php |
Then it seems there are 2 separate issues. This one is about default registered workers. |
Hi Tomas
in a recent update, the
PushTagReleaseWorker
andTagVersionReleaseWorker
release workers are now always included by default in the release process.In our company, we have a custom release process which requires us to create custom release workers, two of them that fill the role of the default release workers, amongst other things.
It was working well prior the update, but now the two default release worker try to do their thing, which causes some conflict (one of our release workers takes care of creating the local tag, which the
TagVersionReleaseWorker
also tries to do).What would be the most elegant way to disable this behavior?
Thanks for your help.
The text was updated successfully, but these errors were encountered: