Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question/feature_request(interface): images overlaps close button #9

Open
Kristinita opened this issue Oct 21, 2020 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Kristinita
Copy link

1. Summary

Currently, images may overlap the close button element. I couldn’t find how I can fix it.

2. Argumentation

For mobile devices users current behavior may be not best.

  1. Design — I’m not sure if seeing the close button solely partially is the best web-design solution.
  2. Accessibility — when the button isn’t visible, it may not be intuitive for users to understand how to exit the hes-gallery.

3. MCVE

I opened hes-gallery demo page in Firefox → I ran Responsive Design Mode → I made the screen small:

Partially close button

The dog image partially overlaps the close button.

I made the screen even less:

No close button

The close button aren’t visible.

4. Not helped

4.1. z-index

We can prioritize left and right arrows rather than images:

#hgallery button
    z-index inherit

Example result:

Visible arrows

But I couldn’t find, how I can get the similar behavior for close button. It realized as pseudo-element #hg-bg::after (and possibly is not the best idea). I read about z-index for pseudo-elements on the Stack Overflow, but I couldn’t find, how I can solve the problem from this issue.

Thanks.

@demtario demtario added bug Something isn't working good first issue Good for newcomers labels Oct 28, 2020
@demtario
Copy link
Owner

Hi, to fix this, I think we need to rework this close button to be own element in the DOM structure.

Now it is just a pseudo-element on the background, and that probably complicates the whole problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants