add mentions toggle #2434
Draft
add mentions toggle #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/mentions
branch
2 times, most recently
from
1963274 to
3dfa17c
Compare
|
ftr, required notification flow is drafted at https://github.com/deltachat/interface/blob/main/notification-flow.md and looks like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds a "Mentions" toggle to the settings; to keep notification things together, a new NotificationsViewController is created.
as a bonus, a link for the system settings is added as well, making all relevant notification settings directly accessible:
TODO: apply reply-logic from android wrt groups, also check if isMention should behave differently for groups
counterpart of deltachat/deltachat-android#3456
closes #2429