-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Make the individual chat list more accessible. #2141
Comments
@MarcoZehe merci beaucoup for filing all the accessibility issues! I want to focus on fixing them for the 1.16 series. The message list will receive a rewrite and in this process i want to fix this issues :) |
WofWca
added a commit
that referenced
this issue
Oct 30, 2024
Closes #2141 Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops. TODO: - [ ] Address the TODOs in the code - [ ] Manage what's gonna be the initially active message, because initially they're all active, so tabbing to the messages list from the top selects the first rendered one as the active one. #4292 could help with this. This is also not great for performance: changing `tabindex` on a bunch of messages makes them all re-render. And otherwise, we probably want to update which one is the active one as new messages arrive.
WofWca
added a commit
that referenced
this issue
Oct 30, 2024
Closes #2141 Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops. TODO: - [ ] Address the TODOs in the code - [ ] Manage what's gonna be the initially active message, because initially they're all active, so tabbing to the messages list from the top selects the first rendered one as the active one. #4292 could help with this. This is also not great for performance: changing `tabindex` on a bunch of messages makes them all re-render. And otherwise, we probably want to update which one is the active one as new messages arrive. - [ ] The interactive items with `onClick` must be actual semantic `<button>`s. See #4210 for reference.
9 tasks
WofWca
added a commit
that referenced
this issue
Oct 30, 2024
Closes #2141 Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops. TODO: - [ ] Address the TODOs in the code - [ ] Manage what's gonna be the initially active message, because initially they're all active, so tabbing to the messages list from the top selects the first rendered one as the active one. #4292 could help with this. This is also not great for performance: changing `tabindex` on a bunch of messages makes them all re-render. And otherwise, we probably want to update which one is the active one as new messages arrive. - [ ] The interactive items with `onClick` must be actual semantic `<button>`s. See #4210 for reference.
WofWca
added a commit
that referenced
this issue
Oct 31, 2024
Closes #2141 Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Nov 3, 2024
Closes #2141 Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 19, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 19, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 20, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 20, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 23, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 23, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 23, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops.
WofWca
added a commit
that referenced
this issue
Dec 23, 2024
Closes #2141. Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops. This appears to implement the Grid pattern: https://www.w3.org/WAI/ARIA/apg/patterns/grid/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposed solution
Implement the [listbox]https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox) design pattern, but with a few extras:
The text was updated successfully, but these errors were encountered: