Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where after clear chat, new self sent messages are not shown in MessageView #3994

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

farooqkz
Copy link
Collaborator

@farooqkz farooqkz commented Jul 1, 2024

This fixes the bug. But I suspect there are far more bugs here because of usage of React.memo. I might be wrong, however so let's wait and see.

Fixes #3991

@farooqkz farooqkz requested a review from WofWca July 1, 2024 12:15
@farooqkz farooqkz requested a review from r10s July 1, 2024 12:19
@hpk42
Copy link
Contributor

hpk42 commented Jul 1, 2024

There seem to be a lot of unrelated changes in changelog whitespacing.

@hpk42
Copy link
Contributor

hpk42 commented Jul 1, 2024

also which bug is fixed by this? If it's an existing issue please properly reference it with "fixes #..." so it automatically is referenced bi-directionally.

CHANGELOG.md Outdated Show resolved Hide resolved
src/renderer/components/message/MessageList.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, I'd revisit / remove CHANGELOG changes. Otherwise it's merge-able.

@nicodh
Copy link
Contributor

nicodh commented Jul 3, 2024

I just tested this PR and it didn't fix the problem. The new message is still shown only in Chatlist but the message list stays empty...

@Simon-Laux Simon-Laux marked this pull request as draft July 4, 2024 22:28
@Simon-Laux Simon-Laux added the bug Something isn't working label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message view not always updated
6 participants