Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcard staging polishing needed #3968

Open
r10s opened this issue Jun 20, 2024 · 2 comments
Open

vcard staging polishing needed #3968

r10s opened this issue Jun 20, 2024 · 2 comments
Labels
good first issue Good for newcomers polish
Milestone

Comments

@r10s
Copy link
Member

r10s commented Jun 20, 2024

thanks for making vcard nicer at #3948

there are some minors that did not make it to the PR review:

  • staged vcards show the "pointing finger cursor", which does not make sense as nothing happens when tapping the vcard

  • there is no padding left of the vcard's avatar, which looks bad. i'd add same padding as above the vcard's avatar

Screenshot 2024-06-20 at 15 21 01

EDIT: same is true for staged files (the missing padding does not look so bad in case of files, the cursor is wrong as well), so, in case both share the same code, that can be fixed together

@Simon-Laux
Copy link
Member

Simon-Laux commented Jun 21, 2024

even with those suggestions it will still really not look good, would be better to also give it a slight background, margin, padding and rounded corners IMO

@Simon-Laux Simon-Laux added this to the New composer milestone Jun 21, 2024
@Simon-Laux Simon-Laux added good first issue Good for newcomers polish labels Jun 21, 2024
@r10s
Copy link
Member Author

r10s commented Jun 21, 2024

surely one can improve beyond fixing the most obvious design bugs.

the two points are the minimum to not consider the design buggy - the result fits somehow to other staged item then - and there is no need to wait for "new composer"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers polish
Projects
None yet
Development

No branches or pull requests

2 participants