Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --create-namespace flag #32

Open
riker09 opened this issue Jun 8, 2020 · 8 comments
Open

Add --create-namespace flag #32

riker09 opened this issue Jun 8, 2020 · 8 comments

Comments

@riker09
Copy link
Contributor

riker09 commented Jun 8, 2020

Since you already have the --install flag present I was wondering if there is anything blocking the support of --create-namespace? This will create the provided namespace when installing a new helm Chart in an ephemeral environment. Should I provide a PR for that?

@mhuhmanpax8
Copy link

Hey @riker09 are you still planning to add support for this? I'd love to have this added, but I'm not sure I have the time to do it.

@riker09
Copy link
Contributor Author

riker09 commented Jul 7, 2020

Sure, I could do that. How about merging my other PRs first? They mostly contain bugfixes. That will make working on a new feature much easier. (IMHO)

@mhuhmanpax8
Copy link

I'd love to, but I'm not a contributor to the repo ;)

@riker09
Copy link
Contributor Author

riker09 commented Jul 8, 2020

Okay, then who's in charge here? Whose leg I gotta hump to get a dry martini around here...? 😄

@colinjfw
Copy link
Collaborator

@riker09 Thanks for all your work on this repository, would you be interested in being a maintainer?
I am definitely guilty of being a bit slow on these pull requests :(

@riker09
Copy link
Contributor Author

riker09 commented Jul 14, 2020

Thank you very much for your kind offer, but I'm perfectly happy with my contributor role. I love Open Source and contributing, even If that means waiting a little longer.

@colinjfw
Copy link
Collaborator

Sounds good 👍 quite a smart choice :)

@riker09
Copy link
Contributor Author

riker09 commented Jul 27, 2020

It took me a little longer than originally anticipated, but here's my take on this. I checked with Helm v2, it does not seem to have a similar mechanism so I'll add that flag only when the user explicitly requests helm3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants