Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip out kubectl commands from journey tests #978

Open
cmwylie19 opened this issue Jul 23, 2024 · 2 comments
Open

Strip out kubectl commands from journey tests #978

cmwylie19 opened this issue Jul 23, 2024 · 2 comments

Comments

@cmwylie19
Copy link
Collaborator

Describe what should be investigated or refactored

There are several instances that we are using kubectl instead of the native KFC commands to interact with kubernetes resources in the journey tests. This is tech debt since KFC is the native way we interact with K8s in Pepr and KFC has come a long way since the first journey tests were written

Links to any relevant code

journey/pepr-deploy.ts

Additional context

Add any other context or screenshots about the technical debt here.

@cmwylie19 cmwylie19 self-assigned this Aug 1, 2024
@cmwylie19
Copy link
Collaborator Author

In further review, it does not make sense to strip these out IMO.

Kubernetes-fluent-client needs a kind in which to apply, in some cases that use kubectl we are applying files with several types. Due to this, we would not be able to remove kubectl as a dependency.

Image

@cmwylie19
Copy link
Collaborator Author

The path forward would be to parse the generated files and interpret the kinds and use KFC apply when the kinds are interpreted

@cmwylie19 cmwylie19 removed their assignment Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant