Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return session id for upload methods #95

Open
rjanjua opened this issue Aug 17, 2023 · 2 comments
Open

return session id for upload methods #95

rjanjua opened this issue Aug 17, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@rjanjua
Copy link
Collaborator

rjanjua commented Aug 17, 2023

User Story
As a user
I want to be able to check the status of the session I just uploaded
So that I know my upload was successful

Relevant Links

Acceptance Criteria

  • all upload methods return session id
  • upload methods return details of session success
@elundaeva
Copy link
Contributor

+1, this was quite a blocker in the Cambridge University trial. Our contact there was trying to upload 2K files, but only PDF files were coming through, no TXTs. The session status looked as if all went well, and it was quite frustrating for the customer to not see in the outputs what files failed and why. Rohan had to investigate further to be able to unblock, but ideally the customers would be able to troubleshoot such upload issues themselves based on error messages.

@ArzelaAscoIi
Copy link
Member

@rjanjua So this means that in addition to the returned upload summary we need to add the session_id to the S3UploadSummary object, right ?

We would need to extend the implementation of this PR, right? #101

@ArzelaAscoIi ArzelaAscoIi added the good first issue Good for newcomers label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants