Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that we expect models without softmax activation at the end #94

Open
cofri opened this issue Jul 8, 2024 · 0 comments
Open

Comments

@cofri
Copy link
Contributor

cofri commented Jul 8, 2024

Some methods can raise an error which is difficult to understand when a model with softmax is used. For example, VIM tries to get weights of the last layer. If last layer is Softmax, an error is raised:

W, b = self.feature_extractor.get_weights(-1)

Moreover, other methods (e.g. VIM, Energy) do not throw an error if softmax is present. But the performance are very poor and not as expected.

Suggestions:

  • clarify documentation/docstrings/etc. to force users to end their models with logits
  • OR ensure that models used do not end with activation (error assertion)
  • OR automatically remove last activation of model when fit().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant