dcrdata/exchanges: connect to signalR websocket without signalR client #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove external dependency used to connect to a signalR websocket. - Fix an error in the exchanges live test. - Update bittrex signalR websocket version.
ukane-philemon
commented
Dec 8, 2022
|
Excellent work with this. Really simplifies things as a bonus on top of eliminating the dependency. |
ukane-philemon
commented
Dec 9, 2022
|
Good work, but looks like trex was the only consumer of microsoft nonsense, so we'll close this this update. I really do appreciate it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
connectSignalRWebsocketfunction which is used to connect to asignalRwebsocket without a signalR client. The connection is done in three steps (negotiate,connect,start) and this makes it easy to connect to asignalRwebsocket without having to manage thesignalRwebsocket connection separately from the regular websocket connection used by other exchanges. Closes #1818bittrexsignalRwebsocket version.For a quick test: