refactor(core): add replace expressions for validating admission policy patch #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
fix/core/replace-validations
branch
from
98ad3b1 to
0ed0193
Compare
fl64
approved these changes
Nov 1, 2024
fl64
changed the title
danilrwx
pushed a commit
that referenced
this pull request
Nov 5, 2024
…cy patch (#489) add replace expressions for validating admission policy patch Signed-off-by: yaroslavborbat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add replace expressions for validating admission policy patch
Why do we need it, and what problem does it solve?
Replace the expressions for the ValidatingAdmissionPolicy kubevirt-node-restriction-policy.
This is necessary because of the kube-api-rewriter that changes the labels.
What is the expected result?
Checklist