Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): notify user if the virtual machine cannot be restarted immediately #477

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat(vm): notify user if the virtual machine cannot be restarted immediately #477

merged 1 commit into from
Oct 30, 2024
+149 −191

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Oct 28, 2024 •
edited
Loading

Description

  1. Refactored SyncKvvmHandler.
  2. Added a warning that restarting the virtual machine can be dangerous, as not all dependencies may be ready yet.
  3. Fixed the bug with outdated changes in .status.restartAwaitingChanges.
  4. Improved error messages for the user.
  5. Removed the use of the deprecated conditions.Manager.
  6. Retry in importer pod now lasts not for 3 seconds, but for about 1 minute.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k force-pushed the feat/vm/configuration-applied branch 5 times, most recently from aed9672 to 0a29121 Compare October 29, 2024 11:52
@Isteb4k Isteb4k marked this pull request as ready for review October 29, 2024 11:52
yaroslavborbat
yaroslavborbat previously approved these changes Oct 30, 2024
View reviewed changes
@Isteb4k Isteb4k force-pushed the feat/vm/configuration-applied branch from 0a29121 to 5016ff4 Compare October 30, 2024 09:09
@Isteb4k Isteb4k force-pushed the feat/vm/configuration-applied branch from 5016ff4 to 357b9d8 Compare October 30, 2024 13:16
@Isteb4k Isteb4k merged commit 7efe3d9 into main Oct 30, 2024
11 checks passed
@Isteb4k Isteb4k deleted the feat/vm/configuration-applied branch October 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

Assignees

@Isteb4k Isteb4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isteb4k @yaroslavborbat