feat(vmop): first implementation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavborbat
force-pushed
the
feat/vmop/impl
branch
from
c88c1fb to
d07d0bf
Compare
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vmop/impl
branch
from
d07d0bf to
f4729bd
Compare
Isteb4k
requested changes
Feb 6, 2024
images/virtualization-controller/pkg/controller/vmop/vmop_controller.go
Outdated
Show resolved
Hide resolved
images/virtualization-controller/pkg/controller/vmop/vmop_reconciler_state.go
Outdated
Show resolved
Hide resolved
images/virtualization-controller/pkg/controller/vmop/vmop_reconciler_state.go
Outdated
Show resolved
Hide resolved
images/virtualization-controller/pkg/controller/vmop/vmop_reconciler_state.go
Outdated
Show resolved
Hide resolved
images/virtualization-controller/pkg/controller/vmop/vmop_reconciler.go
Outdated
Show resolved
Hide resolved
images/virtualization-controller/pkg/controller/vmop/vmop_reconciler.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vmop/impl
branch
from
f4729bd to
1d15d6b
Compare
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vmop/impl
branch
from
a57c641 to
55a7b79
Compare
Isteb4k
approved these changes
Feb 9, 2024
Signed-off-by: Yaroslav Borbat <[email protected]>
diafour
reviewed
Feb 9, 2024
images/virtualization-controller/pkg/controller/vmop/vmop_webhook.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Feb 9, 2024
images/virtualization-controller/pkg/controller/vmop/vmop_webhook.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Feb 9, 2024
images/virtualization-controller/pkg/controller/vmop/vmop_reconciler.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Feb 9, 2024
…ook.go Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
…ook.go Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
…nciler.go Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
fl64
added a commit
that referenced
this pull request
Aug 14, 2024
fl64
added a commit
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Pavel Tishkov <[email protected]>
fl64
added a commit
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Pavel Tishkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation resource VirtualMachineOperation.
The VirtualMachineOperation custom resource allows for declarative management of a working virtual machine. It enables actions such as stopping, starting, and restarting the virtual machine.
Why do we need it, and what problem does it solve?
The VirtualMachineOperation resource is needed to provide a high-level abstraction for managing virtual machines. It solves the problem of efficiently and easily controlling the state of virtual machines through a declarative approach, rather than relying on manual, time-consuming operations.
What is the expected result?
VirtualMachineOperation is an immutable resource. After deployment, it can have 4 phases of status: Completed, Failed, InProgress, Pending.