Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Fix CSI NFS v3(tcp) support #37

Merged
merged 35 commits into from
Sep 25, 2024
Merged

[controller] Fix CSI NFS v3(tcp) support #37

merged 35 commits into from
Sep 25, 2024

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Sep 20, 2024

Description

This PR addresses issues with NFS v3 support in the CSI controller and node containers by introducing the following changes:

  1. Socket mounting: Added mount of the /run/rpcbind.sock socket to both the CSI controller and CSI node containers.
  2. Init Container: Added an init container that ensures the availability of the /run/rpcbind.sock socket before starting.
  3. Distroless Image Enhancements: Included the /etc/netconfig file and the libnss_files library in the distroless image to enable CSI to mount NFS v3 over TCP.

Why do we need it, and what problem does it solve?

The changes ensure proper support for NFS v3 over TCP in CSI deployments. Without these adjustments, the CSI controller and node were unable to mount NFS v3 volumes due to missing libraries and socket forwarding issues.

What is the expected result?

  • Successful mounting of NFS v3 volumes over TCP by the CSI controller and node.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin self-assigned this Sep 23, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin changed the title fix csi v3 support [controller] Fix CSI NFS v3(tcp) support Sep 25, 2024
@AleksZimin AleksZimin requested a review from duckhawk September 25, 2024 09:56
@AleksZimin AleksZimin marked this pull request as ready for review September 25, 2024 09:56
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin added the bug Something isn't working label Sep 25, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin merged commit fab135b into main Sep 25, 2024
4 of 7 checks passed
@AleksZimin AleksZimin deleted the fix-v3-support branch September 25, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants