Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

lazy-img attributes img-height img-width don't work #1553

Open
1 task
flatmax opened this issue Aug 18, 2022 · 3 comments
Open
1 task

lazy-img attributes img-height img-width don't work #1553

flatmax opened this issue Aug 18, 2022 · 3 comments

Comments

@flatmax
Copy link

flatmax commented Aug 18, 2022

Affected part of DeckDeckGo

  • Web Components

Reproduction

Can' use img-width and img-height

Steps to reproduce:

  1.     <deckgo-lazy-img img-src=url img-width=50 img-height=60>        </deckgo-lazy-img>
    

Expected Behavior

The image to resize

Actual Behavior

The image doesn't resize

Environment

  • Browser(s): chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): linux
@peterpeterparker
Copy link
Contributor

Did you inspect the shadowed dom, are the width and height applied?

As you can see in the component here

return <img alt={this.imgLoaded ? (this.imgAlt ? this.imgAlt : this.imgSrc) : ''} loading={this.loading} sizes={this.imgSizes ? this.imgSizes : undefined} intrinsicsize={this.intrinsicsize}
width and height should be set if the props are set.

@flatmax
Copy link
Author

flatmax commented Aug 18, 2022

Oh ok - are you saing that the attributes img-width and img-height aren't working ? I should use the properties instead ?

@peterpeterparker
Copy link
Contributor

Actually I'm saying these should work but asking if you had a look to the shadowed content to see if anything seems not to work as expected?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants