-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Changelog and Copyright format #154
Comments
…e format. Related to: debops/docs#154
http://keepachangelog.com/ looks nice! Dug a bit into the project and have a few minutes still to listen to the referenced podcast. After checking out your examples I found a few things I would do differently:
Other than that I think it is a improvement we should implement. |
Ad. 1: I removed the copyright file because after compiling all of the documentation in one place it just basically repeats over and over... I suppose that if it's important, I would move id to the root directory of the repository similar to how Ad. 2: Agreed. Ad. 3: reStructuredText provides that automatically. When you hover over section titles in your example changelog, you can see small icons which allow you to get a target link for that section. Just a bit of magic of the RST format. :-) |
To 1: About the contributors section that is a good idea. Yes, it is important AFAIK: https://www.gnu.org/licenses/gpl-howto.html. I would leave this as is. To 3: I know 😉 Have you clicked on the |
Ad. 1: The GNU project suggests inclusion of the copyright notice in every source file... I would go with putting a
After that, as I understand it, this copyright would apply to all files in the repository, unless a different copyright is included in a file. For example, profile_tasks callback plugin is licensed under MIT License, which is included in the file itself. Do you think that this would be an acceptable solution? Ad. 3: Well, that's neat but in the plaintext format it looks... well, not so neat:
The links also strongly bond the project to GitHub, so it would be much harder to change the hosting domain if ever we decide to move. |
Ad. 1: Sounds good. I think that should also do the trick. But I would suggest to stay with RST and maybe still include it in the docs. Related to #132. Maybe @danstender can step in as dealing with licenses is an important part of packaging software. Maybe @danstender has also suggestions for the change log format. @danstender Awesame work by the way! Ad. 3: Right. I have tried a bit to use hyperlink definitions and such but this was the most robust solution I did come up for RST. The strongly bond the project to GitHub is not an issue as it can be fixed by one global replace over all repos of the project (ref: debops/debops#120 (comment)). Automated edits will be needed for migrating to other hostings platforms anyway. About the not so neat looking part in the source. Well, right, but what counts is the rendered version. |
…e format. Related to: debops/docs#154
…e format. Related to: debops/docs#154
…e format. Related to: debops/docs#154
A way to easily see the changes on GitHub is definitely nice, but I don't like that it messes the readability of the text format. So, how about this compromise:
This should make headers human readable and provide nice links in the HTML version. I've prepared an example debops.pki Changelog to see the finished version. What do you think, @ypid? |
As for inclusion of the |
Sounds good. Lets go with that.
I would include it at the same position in the docs as currently done. |
…e format. Related to: debops/docs#154
Related to: debops/docs#154
From @drybjed in debops/debops-policy#9 (comment)
Adding a bit more infos to the git tags is a good idea. I would propose: ${Role_name_or_repo_name} vX.Y.Z Changelog: https://docs.debops.org/en/latest/debops-policy/docs/changelog.html#debops-policy-v0-1-0-unreleased I would not put the changelog in the git tags because then the changelog can not be edited afterwards (which might come in handy for fixing typos and improving rst/Sphinx stuff). Also to avoid redundancy as you said. |
And who's going to have to update both links on every release and remember to paste all that in the tag description? :-) How about moving this to the API status page? Each role could have its own page with changelog embedded (I'm not sure about the RST->MD conversion for jekyll though) or a list of links that point to each tag |
According to our current policy, that would be you :) But there are only two URLs and you should be able to write a little script which preseeds/autogens the git tag message.
It is already available in the docs. We could include a API parameter like
I am not sure what advantage that would have. debops.org is currently in rework a bit because you intended to move the wiki to debops.org. |
…e format. Related to: debops/docs#154
After finding http://keepachangelog.com/ I propose to over time switch the Changelog format to something more readable. I would also move the Copyright file contents into the Changelog, since the contributor information is closely related.
I've updated changelogs in two roles so far to test the new format, what do you think about the results?
New
debops.php
role, not yet released: https://github.com/debops/ansible-php/blob/master/CHANGES.rstThe
debops.nodejs
role: https://github.com/debops/ansible-nodejs/blob/master/CHANGES.rstdebops.nodejs
changelog on the documentation site: http://docs.debops.org/en/latest/ansible/roles/ansible-nodejs/docs/changelog.htmlThe text was updated successfully, but these errors were encountered: