Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipped invalid command 'info' #17

Open
def- opened this issue Dec 8, 2019 · 5 comments
Open

skipped invalid command 'info' #17

def- opened this issue Dec 8, 2019 · 5 comments

Comments

@def-
Copy link
Member

def- commented Dec 8, 2019

Needed as a dummy command in votes

@def-
Copy link
Member Author

def- commented Dec 8, 2019

Still seems to work, so maybe not that important.

@def-
Copy link
Member Author

def- commented Dec 16, 2019

Probably this causes the problem that current server type is not shown in votes, so please implement it or some similar command.

@ChillerDragon
Copy link
Contributor

The command is implemented and also works from chat or remote console see:

CHAT_COMMAND("info", "", CFGFLAG_CHAT|CFGFLAG_SERVER, ConInfo, this, "Shows info about this server")

But chat commands are not found by CConsole::FindCommand

CConsole::CCommand *CConsole::FindCommand(const char *pName, int FlagMask)
{
for(CCommand *pCommand = m_pFirstCommand; pCommand; pCommand = pCommand->m_pNext)
{
if(pCommand->m_Flags&FlagMask)
{
if(str_comp_nocase(pCommand->m_pName, pName) == 0)
return pCommand;
}
}
return 0x0;
}

@fokkonaut
Copy link
Collaborator

What's the problem here?

@def-
Copy link
Member Author

def- commented Jan 20, 2020

That we use the info command extensively, see https://github.com/ddnet/ddnet-scripts/blob/master/servers/types/brutal/votes.cfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants