feat: added SHINKAI_NODE_LOCATION #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agallardol
had a problem deploying
to
development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several enhancements to the Deno runner:
Added support for configuring the Shinkai Node location via the
ShinkaiNodeLocationstruct. This allows specifying the protocol, host, and port of the Shinkai Node.Introduced the
RunnerTypeenum to specify whether to run Deno in the host or Docker environment. Theforce_deno_in_hostoption has been replaced withforce_runner_typeto accommodate this change.Updated the
runmethod inDenoRunnerto respect theforce_runner_typeoption. If not specified, it falls back to the previous behavior of running in Docker if available, otherwise in the host.Modified the Deno execution environment to pass the
SHINKAI_NODE_LOCATIONenvironment variable, allowing the running code to access the configured Shinkai Node location.Added tests to verify the behavior of running with different Shinkai Node locations in both host and Docker environments.
These changes provide more flexibility in configuring the Deno runner and enable seamless integration with the Shinkai Node, regardless of the execution environment.