Current Issues with adapter #512
Closed
cody-scott
started this conversation in
General
Replies: 2 comments
-
For some additional context, we are using it pretty simply with dagster (not using incremental or snapshots), so hearing how that is having issues are would be helpful as well. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Closing discussion as the primary issue (tests) have now been addressed |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello,
Sounds like there is some drift between the current adapter and what was available in 1.4. Hoping we can put down here the issues everyone is having and try and get a plan together to move it forward.
For background, I had put the original changes for moving to 1.7 through to try and start bringing the adapter up to the current state (at the time). The plan at that stage was for it to pass the current test suite, which it did. Since then its become apparent there has been drift from the base DBT test cases and what is captured in this adapter. This also inherited from dbt-fabric (which in itself looks stale), so its unclear what changes from there are now cascading into here.
My opinion is it should be critical to bring the current adapters test case up to date with the DBT suite.
It also sounds like there is issues with how the adapter is materializing. Some examples (#509, #481).
What issues are others having?
Not being a maintainer, I don't have much ability to push changes through, but I'm hoping we can all work towards updating and refreshing the test suite, then moving on to the other issues around materialization.
Beta Was this translation helpful? Give feedback.
All reactions