Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update IAM auth to warn that user field is ignored #846

Open
3 tasks done
colin-rogers-dbt opened this issue Jun 14, 2024 · 1 comment
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@colin-rogers-dbt
Copy link
Contributor

colin-rogers-dbt commented Jun 14, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-redshift functionality, rather than a Big Idea better suited to a discussion

Describe the feature

As seen in #845

Someone can reasonably change their profile to use IAM auth and we still allow them to specify a user field despite redshift resolving to a different database user at runtime. This can result in confusion where someone thinks they are using a different database user than they actually are.

We should update this section to not pass this to redshift at all and instead add a warning that the field is being ignored.

Describe alternatives you've considered

Explicitly not allowing user to be passed with IAM auth method (could create a breaking change)

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@adam-bloom
Copy link

I'm confused here - we currently use this field, and it behaves as expected. In fact, our IAM auth policies require that the connections are initiated with a given db_user field. Is this a difference between serverless redshift and regular redshift? Is there another way we'd be able to pass the user if this is removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants