Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-700] [Bug] proper handling of cname-based connections required higher minimum version of boto3 #532

Closed
2 tasks done
dataders opened this issue Jul 13, 2023 · 0 comments · Fixed by #530
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@dataders
Copy link
Contributor

Is this a new bug in dbt-redshift?

  • I believe this is a new bug in dbt-redshift
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

To ensure users can make use of cname-aliased redshift clusters, we should increase the minimum required version of boto3 to align with the driver upon which this package depends, redshift_connector, which purportedly is 1.26.157.

aws/amazon-redshift-python-driver@1eaac8d (redshift_connector's diff comparing 2.0.913 to 2.0.912) reveals the following lines of code

if info.iam and info.is_cname:
    if IdpAuthHelper.get_pkg_version("boto3") < Version("1.26.157"):
        raise ModuleNotFoundError(
            "boto3 >= 1.26.157 required for authentication with Amazon Redshift using custom domain name. "
            "Please upgrade the installed version of boto3 to use this functionality."
        )

Expected Behavior

x

Steps To Reproduce

x

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-redshift:

Additional Context

No response

@dataders dataders added bug Something isn't working triage labels Jul 13, 2023
@github-actions github-actions bot changed the title [Bug] proper handling of cname-based connections required higher minimum version of boto3 [ADAP-700] [Bug] proper handling of cname-based connections required higher minimum version of boto3 Jul 13, 2023
@dataders dataders linked a pull request Jul 13, 2023 that will close this issue
4 tasks
@dbeatty10 dbeatty10 removed the triage label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants