Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update broken link in ARCHITECTURE.md #10383

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[docs] Update broken link in ARCHITECTURE.md #10383

wants to merge 2 commits into from

Conversation

farmanp
Copy link

@farmanp farmanp commented Jul 1, 2024 •
edited by dataders
Loading

Point DBT Adapters to correct documentation

resolves: #10384

Problem

"adapters" link is pointing to a page "Not Found"

Solution

It's pointing to the correct page, per discussion

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@farmanp
Update ARCHITECTURE.md
2a59785 
Point DBT Adapters to correct documentation
@farmanp farmanp requested a review from a team as a code owner July 1, 2024 04:35
@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 1, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @farmanp

@github-actions github-actions bot added the community This PR is from a community member label Jul 1, 2024
@farmanp farmanp changed the title [farmanp//dbt-core] - Update ARCHITECTURE.md [farmanp/dbt-core] - Update ARCHITECTURE.md Jul 1, 2024
@dataders dataders mentioned this pull request Jul 1, 2024
Open
@dataders dataders changed the title [farmanp/dbt-core] - Update ARCHITECTURE.md [docs] Update broken link in ARCHITECTURE.md Jul 1, 2024
@dataders dataders mentioned this pull request Jul 1, 2024
Open
2 tasks
@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 1, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @servis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community This PR is from a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Adapters link goes to 404 on Architecture page
1 participant
@farmanp