Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Black into CI #1785

Closed
bbugyi200 opened this issue Jul 3, 2021 · 2 comments
Closed

Integrate Black into CI #1785

bbugyi200 opened this issue Jul 3, 2021 · 2 comments

Comments

@bbugyi200
Copy link

bbugyi200 commented Jul 3, 2021

While working on #1784, I spent too much time reformatting my code to make it look prettier (e.g. by wrapping long lines). Would there be any interest in integrating black into jedi's CI process? This is quickly becoming the standard (for good reason IMO). We would, ofcourse, have to blacken the codebase first.

@davidhalter
Copy link
Owner

No. I don't want to reformat everything for now. This does not mean this is a no forever, it's just for now I don't want it.

BTW: I also think that code styles is something devs obsess over and it shouldn't be that important.

@bbugyi200
Copy link
Author

bbugyi200 commented Jul 4, 2021

No. I don't want to reformat everything for now. This does not mean this is a no forever, it's just for now I don't want it.

@davidhalter I respect your decision. If this project does ever make this change, you should also consider integrating isort into CI. Adding / sorting imports manually is also something I don't like doing.

BTW: I also think that code styles is something devs obsess over and it shouldn't be that important.

I 1000% agree. That's why I use black, so I never have to think about code styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants