Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior when navigating away from request_ticket_v1.html #21

Open
cesium12 opened this issue Jun 16, 2012 · 3 comments
Open

Weird behavior when navigating away from request_ticket_v1.html #21

cesium12 opened this issue Jun 16, 2012 · 3 comments
Labels

Comments

@cesium12
Copy link
Collaborator

After the popup opens, if I type certain URLs in the address bar (including https://webathena.scripts.mit.edu, https://scripts.mit.edu, https://mit.edu, https://linerva.mit.edu) but not others (including http://scripts.mit.edu, http://mit.edu, https://google.com, http://webathena.scripts.mit.edu [even though that redirects to https://]), the popup closes as soon as the page starts loading. Otherwise, it stays open, but iff I navigate back to request_ticket_v1.html (via history or url bar) and then go to one of the first set, it closes.

@davidben
Copy link
Owner

Ugh, I bet this is a quirk of when Chrome does and doesn't keep pages in the same process (unit of similar-origin related browsing contexts... https://**.mit.edu are all similar-origin). This has an effect on things like window.name namespaces, though I'd be kinda disturbed if WinChan used that. There's probably something else going on. I read through the code before, but it'd be good to do it again.

I guess this is why BrowserID does a popup? So you can't navigate it away... I imagine Chrome will also consistly enter popup mode if we actually pass in a window_features to WinChan.open.

@cesium12
Copy link
Collaborator Author

Yeah, I'm pretty sure we want to make it always a popup with navigation disabled and such.

@davidben
Copy link
Owner

We may need to experiment a bit to see exactly what browsers do. The features argument isn't really all that standard between browsers. The spec officially says to just ignore it, though that doesn't necessarily mean much. (I imagine the reasoning is that it's very dependent on your browser's UI and probably not incredibly interoperable anyway. The defaults in WinChan already acted different between Chrome and Firefox. Though that could easily be some UA sniffing.) Also we don't really want to hide the location bar, although it shouldn't be possible to hide that these days.

It may be worth investigating if we can prevent it from closing in the first place, in addition from tailoring the exact shade of popup. That seems a pretty poor choice on Mozilla's part. I could easily imagine the distinction between popup and window is less clear on a mobile browser. Maybe popups are still navigable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants