-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rango renames bookmarks to current tab title #252
Comments
Oh, this is bad. I see why this is happening. I think I can prevent this if I make sure that the current url matches that of the bookmark and the title without decorations contains the title of the bookmark. I'll see if I can fix it soon and make a release. |
I for one add links to the bookmarks toolbar and remove (to only have the favicons) or rename the title for beeing shorter. |
I need to use the onChange event too because of the way bookmarks are saved in Chrome. When the bookmark popup appears the bookmark is saved. We change the title after onCreated is triggered, but when the user hits "done" the title of the bookmark will be changed again to the value of the input field of the popup window. I think the solution I have come up with is robust and I don't think we'll have any more issues. |
steps to reproduce:
The text was updated successfully, but these errors were encountered: