Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rango renames bookmarks to current tab title #252

Closed
gpunktschmitz opened this issue Dec 5, 2023 · 3 comments · Fixed by #254
Closed

rango renames bookmarks to current tab title #252

gpunktschmitz opened this issue Dec 5, 2023 · 3 comments · Fixed by #254

Comments

@gpunktschmitz
Copy link

steps to reproduce:

  1. enable rango
  2. open "google.com" and add it to the bookmark toolbar
  3. open new tab and go to "github.com"
  4. while "github.com" beeing active edit the bookmark "google.com" which was just created
  5. enter anything as new title
  6. the result is that the title of the current tab "github.com" will be used as bookmark title
@david-tejada
Copy link
Owner

Oh, this is bad. I see why this is happening. I think I can prevent this if I make sure that the current url matches that of the bookmark and the title without decorations contains the title of the bookmark. I'll see if I can fix it soon and make a release.

@gpunktschmitz
Copy link
Author

I for one add links to the bookmarks toolbar and remove (to only have the favicons) or rename the title for beeing shorter.
Don't know how to but maybe only "intercept" if the bookmark is added, but not if it is updated?

@david-tejada
Copy link
Owner

I need to use the onChange event too because of the way bookmarks are saved in Chrome. When the bookmark popup appears the bookmark is saved. We change the title after onCreated is triggered, but when the user hits "done" the title of the bookmark will be changed again to the value of the input field of the popup window.

I think the solution I have come up with is robust and I don't think we'll have any more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants