Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route variables #112

Open
1337haxx0r opened this issue Feb 3, 2023 · 1 comment
Open

Route variables #112

1337haxx0r opened this issue Feb 3, 2023 · 1 comment

Comments

@1337haxx0r
Copy link

1337haxx0r commented Feb 3, 2023

Just an idea, to have routes assigned to variables to make routes more dynamic.
I come up with this while was changing bunch of same URLs in the twig template.

Let's say we have this route with 3rd argument as a variable:
$router->add('posts/index', ['controller' => 'Posts', 'action' => 'index'],'post_index');

We can then pass it the same way as route_params to the controller and in addition create a global twig variable (called routes) so it can be accessed from the view.

and instead of having this in twig:
<a href="{{ URL }}posts/index">Test</a>
We could have:
<a href="{{ URL }}{{ routes.post_index }}">Test</a>
Which after render would give
<a href="https://website.com/posts/index">Test</a>

With this solution we'd need only change route in one place, instead of going through bunch of files.

I haven't thought of implementation of it yet though, so if I come up with something - will let you know

@daveh
Copy link
Owner

daveh commented Feb 4, 2023

That's an interesting idea! I'm currently working on a major update for this framework, I'll make a note of this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants