Skip to content

Commit

Permalink
Tweak spoof version config
Browse files Browse the repository at this point in the history
- Remove annoying warning by removing default value for spoof version
  in docker-compose
- Add version spoof to CI to check that it does not introduce build
  failure
  • Loading branch information
ml-evs committed Nov 14, 2024
1 parent 24bb0f9 commit e502e92
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ jobs:
run: |
cp webapp/.env.test_e2e .env
echo "PYDATALAB_TESTING=true" >> pydatalab/.env
echo "SETUPTOOLS_SCM_PRETEND_VERSION=0.11.11rc8" >> pydatalab/.env
- name: Load previously built Docker images
uses: docker/bake-action@v5
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ services:
dockerfile: .docker/server_dockerfile
args:
- WEB_CONCURRENCY=4
- SETUPTOOLS_SCM_PRETEND_VERSION=${SETUPTOOLS_SCM_PRETEND_VERSION}
- SETUPTOOLS_SCM_PRETEND_VERSION
depends_on:
- database
restart: unless-stopped
Expand Down

0 comments on commit e502e92

Please sign in to comment.