Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect "dirty" git working tree #1962

Open
NZJKOL opened this issue Dec 5, 2024 · 1 comment
Open

detect "dirty" git working tree #1962

NZJKOL opened this issue Dec 5, 2024 · 1 comment
Labels
DABs DABs related issues Enhancement New feature or request

Comments

@NZJKOL
Copy link

NZJKOL commented Dec 5, 2024

Describe the issue

When deploy/update a bundle, it will show the Git Branch and Commit Hash-ID.
But if the user has un-committed changes, this technically not correct.

Configuration

Just change any of the files being synced, in your local Git checkout, and do a deploy without doing a "git add / commit" first.

Expected Behavior

It should some how show that the deploy is "dirty", possibly by just suffixing the Commit Hash-ID with -dirty
An example how it can be detected (there might be better options):

[[ -n `git status -s` ]] && echo "dirty"

If it could also detect if the commit is local-only or also pushed to "remote origin", would be a really cool bonus!

Actual Behavior

It just shows the last committed Hash ID, which doesn't reflect that the files and resources might be different than the source-of-truth.

@NZJKOL NZJKOL added the DABs DABs related issues label Dec 5, 2024
@andrewnester andrewnester added the Enhancement New feature or request label Dec 5, 2024
@pietern
Copy link
Contributor

pietern commented Dec 9, 2024

Thanks for posting the issue.

You're right, this is not implemented. The reasoning for not including it out of the gate is that seeing this metadata is primarily helpful for jobs deployed from automation, where the tree will typically be clean and the commits remote.

We'll consider this. I agree that this isn't complete as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DABs DABs related issues Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants