-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative path definition in "paths" mapping not working properly #1755
Comments
@lachniej Thanks for reporting the issue! I didn't apply the relevant changes for library glob expansion as part of #1694 and that's where the first issue you list comes from. A fix for this issue is in #1756 and will be included in the next release later this week. The PyDABs issue you mention ( Could you double check this? |
## Changes Library glob expansion happens during deployment. Before that, all entries that refer to local paths in resource definitions are made relative to the _sync root_. Before #1694, they were made relative to the _bundle root_. This PR didn't update the library glob expansion code to use the sync root path. If you were using the sync paths setting with library globs, the CLI would fail to expand the globs because the code was using the wrong path to anchor those globs. This change fixes the issue. ## Tests Manually confirmed that this fixes the issue reported in #1755.
@pietern thanks for that info. Yeah sorry, I forgot to switch the version back to the supported databricks cli version for pydabs 5.1. Here is actual error.
|
@pietern not sure if you had resolved what is going on with pydabs, but with the pre-release cli version right now dabs is working but pydabs is still returning this |
@lachniej Could you confirm if the latest version of the CLI resolves the issue? It should work for the regular DABs case. I'm not sure about the PyDABs case. |
In attempting to use the paths mapping within the sync in a databricks.yml I am getting various errors when attempting to sync a common folder at the same level as the bundle directory (not the bundle root). It is producing errors both with pydabs and dabs default initialization templates.
Configuration
databricks cli version: 0.227.0 and 0.227.1
pydabs version for pydabs testing: 0.5.1
python version: 3.11
Folder Structure - dabs --using default dabs template--
Folder Structure - pydabs --using default pydabs template--
databricks.yml - dabs
resources/my_bundle_job.yml - dabs
databricks.yml - pydabs
Steps to reproduce the behavior
Please list the steps required to reproduce the issue, for example:
Expected Behavior
Expected behavior would be deployment of bundle along with the shared package for use across multiple bundles within the same repo
Actual Behavior
error - dabs
error - pydabs
OS and CLI version
tested this with databricks cli version: 0.227.0 and 0.227.1
Is this a regression?
does not work in neither version since feature release
Debug Logs
dabs
pydabs
The text was updated successfully, but these errors were encountered: