You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In playing around with the current json loader and datasets beyond IsolatedGalaxy, I've found that large sph particle datasets are pretty slow. e.g., the following json:
takes around 2.5 minutes to load in napari. Most of this time is spent in yt, interpolating the SPH field. While alot of the slowness here may be unavoidable, there are at least three points that are worth looking at I think:
Is there a way to add some napari notification that the interpolation is in progress? The terminal log shows the usual yt notifications, but the napari GUI hangs while it waits for yt to return the interpolated data. Some sort of loading symbol would be nice...
There seems to be a significant differences in loading time between the yt code when executed in napari vs. executing the same yt code in a python shell: executing in napari was almost a whole minute slower. Need to do some more careful profiling to compare.
It might be worth considering a cache system -- the interpolated FRB would be fairly cheap to store on disk so that if you subsequently load an identical json it could reload the previously interpolated FRB. Could have an optional "use_cache" argument in json model. Not an immediate item to do, but may be worth considering in the future.
The text was updated successfully, but these errors were encountered:
In playing around with the current json loader and datasets beyond
IsolatedGalaxy
, I've found that large sph particle datasets are pretty slow. e.g., the following json:takes around 2.5 minutes to load in napari. Most of this time is spent in yt, interpolating the SPH field. While alot of the slowness here may be unavoidable, there are at least three points that are worth looking at I think:
The text was updated successfully, but these errors were encountered: