Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json load failing #121

Closed
chrishavlin opened this issue Feb 8, 2024 · 0 comments · Fixed by #124
Closed

json load failing #121

chrishavlin opened this issue Feb 8, 2024 · 0 comments · Fixed by #124
Labels
bug Something isn't working

Comments

@chrishavlin
Copy link
Collaborator

Bug summary

fresh 3.10.11 env failing to load a valid json at the schema check:

Reproduction
sample json:

{
  "$schema": "yt-napari_0.2.0.json",
  "datasets": [],
  "timeseries": [
    {
      "file_selection": {
        "directory": "",
        "file_pattern": "enzo_tiny_cosmology/DD????/DD????",
        "file_list": null,
        "file_range": [0, 50, 10]
      },
      "selections": {
        "regions": null,
        "slices": [
          {
            "fields": [
              {
                "field_type": "enzo",
                "field_name": "Density",
                "take_log": true
              }
            ],
            "normal": "x",
            "center": {
              "value": [
                0.5,
                0.5,
                0.5
              ],
              "unit": "code_length"
            },
            "slice_width": {
              "value": 1.0,
              "unit": "code_length"
            },
            "slice_height": {
              "value": 0.5,
              "unit": "code_length"
            },
            "resolution": [
              800,
              800
            ],
            "periodic": false
          }
        ]
      },
      "load_as_stack": true,
      "process_in_parallel": false
    }
  ]
}

the error:

Traceback (most recent call last):
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/components/viewer_model.py", line 1205](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/components/viewer_model.py#line=1204), in _open_or_raise_error
    added = self._add_layers_with_plugins(
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/components/viewer_model.py", line 1295](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/components/viewer_model.py#line=1294), in _add_layers_with_plugins
    layer_data, hookimpl = read_data_with_plugins(
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/plugins/io.py", line 77](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/plugins/io.py#line=76), in read_data_with_plugins
    res = _npe2.read(paths, plugin, stack=stack)
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/plugins/_npe2.py", line 63](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/napari/plugins/_npe2.py#line=62), in read
    layer_data, reader = io_utils.read_get_reader(
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/io_utils.py", line 66](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/io_utils.py#line=65), in read_get_reader
    return _read(
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/io_utils.py", line 167](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/io_utils.py#line=166), in _read
    read_func = rdr.exec(
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/manifest/contributions/_readers.py", line 51](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/manifest/contributions/_readers.py#line=50), in exec
    callable_ = super().exec(kwargs=kwargs)
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/manifest/utils.py", line 61](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/npe2/manifest/utils.py#line=60), in exec
    return self.get_callable(reg)(*args, **kwargs)
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/yt_napari/_reader.py", line 37](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/yt_napari/_reader.py#line=36), in napari_get_reader
    if path_is_valid(path):
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/yt_napari/_reader.py", line 53](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/yt_napari/_reader.py#line=52), in path_is_valid
    return schema_version_is_valid(schema_version)
  File "[/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/yt_napari/schemas/_version_comparison.py", line 20](http://localhost:8888/home/chavlin/.pyenv/versions/3.10.11/envs/ytnapari_310/lib/python3.10/site-packages/yt_napari/schemas/_version_comparison.py#line=19), in schema_version_is_valid
    if schema_version is None or pfx not in schema_version:
TypeError: 'in <string>' requires string as left operand, not ModelPrivateAttr

likely a pydantic issue

@chrishavlin chrishavlin added the bug Something isn't working label Feb 8, 2024
@chrishavlin chrishavlin linked a pull request Feb 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant