New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Use maps instead of objects. #211

Open

aikar opened this issue Jan 13, 2020 · 0 comments

aikar commented Jan 13, 2020 •

edited

Loading

In numerous places across the project, standard JS objects are used instead of Maps for Map like data structures.

Maps offer better performance over objects-as-maps, and can be done in places like callback storage (ie object.callbacks[id] = cb;) type patterns.

cote/src/components/time-balanced-requester.js

Line 12 in 8ad0155

this.callbacks = {};

cote/src/components/pending-balanced-requester.js

Line 36 in ac31387

sock.callbacks[cbId].sock = sentSock;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment