Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteService should stop the service #80

Open
jnm2 opened this issue Mar 4, 2019 · 3 comments
Open

DeleteService should stop the service #80

jnm2 opened this issue Mar 4, 2019 · 3 comments
Assignees
@dasMulli
Milestone
1.3.0

Comments

@jnm2
Copy link
Contributor

jnm2 commented Mar 4, 2019

Otherwise, it stays running and in the Services list until the next time it stops for some other reason.

Would it ever make sense to delete and leave running? If so, could you add a bool stopImmediately parameter to DeleteService to mirror the startImmediately parameter on CreateService?
@dasMulli
Copy link
Owner

dasMulli commented Mar 4, 2019

yup i'm all in for stopImmediately

@dasMulli dasMulli self-assigned this Mar 4, 2019
@dasMulli dasMulli added this to the 1.3.0 milestone Mar 4, 2019
@dasMulli
Copy link
Owner

dasMulli commented Mar 4, 2019

There has been #75 before to implement stopping.

The reason i didn't want to put it in immediatly was because ServiceController has a more versatile method of stopping but i guess it should be fine to either copy that code or "just" use ServiceController.

@jnm2
Copy link
Contributor Author

jnm2 commented Mar 4, 2019

@dasMulli I'd have a mild preference for avoiding an extra assembly, and maybe I'd support it by saying it would be more symmetrical on the outside (startImmediately doesn't require the extra assembly). 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasMulli dasMulli

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@dasMulli @jnm2