Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstantReader.revive cannot revive constant fields with a type not defined in the same library as the field #547

Open
natebosch opened this issue Jul 21, 2021 · 0 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@natebosch
Copy link
Member

For instance trying to revive from

@Foo.foo
class Foo {
  static const foo = Deprecated('argument');
}

When we search for potential fields which define this argument, we only search the library that defines Deprecated), and of course never find a field equal to our object.

for (final type in origin!.definingCompilationUnit.types) {

If we could know to search the library defining Foo we'd find it.

@natebosch natebosch added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

1 participant