Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with api docs links #6210

Closed
MaryaBelanger opened this issue Nov 15, 2024 · 2 comments · Fixed by #6211
Closed

Problem with api docs links #6210

MaryaBelanger opened this issue Nov 15, 2024 · 2 comments · Fixed by #6211
Labels
infra.structure Relates to the tools that create dart.dev

Comments

@MaryaBelanger
Copy link
Contributor

Describe the problem

The first two API docs links on the async page (Future and Stream) lead to something that looks like this:
image

The url shows api.dart.dev/stable/dart-async/Stream-class.html
Visiting those pages by following the links directly from api.dart.dev doesn't have any problems, and the link is different: api.dart.dev/dart-async/Stream-class.html, no /stable.

I'm guessing this isn't the only page with issues, I'll check more.

Expected fix

I think the links to api docs on the site need to be adjusted for recent updates to the api docs site.

On which platform(s) did you experience this issue?

No response

Additional context

No response

@MaryaBelanger MaryaBelanger added infra.structure Relates to the tools that create dart.dev from.user Issue raised by user and removed from.user Issue raised by user labels Nov 15, 2024
@MaryaBelanger
Copy link
Contributor Author

Looks like just removing {{site.sdkInfo.channel}} (e.g {{site.dart-api}}/{{site.sdkInfo.channel}}/dart-async/Stream-class.html) does the trick

@jbcormoreche
Copy link

There are also 3 links containing /stable that most likely need to be changed in the firebase.json file.
https://github.com/dart-lang/site-www/blob/main/firebase.json

You can find them at line 151, 355 and 358.
The first two lead to a 404 page, the last one already leads to the right page through a redirect but the /stable part of the link probably needs to be removed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra.structure Relates to the tools that create dart.dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants