Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift2objc] Unify test/unit/filter_test.dart and test/integration/integration_test.dart #1833

Open
liamappelbe opened this issue Dec 19, 2024 · 0 comments
Labels
package:swift2objc type-infra A repository infrastructure change or enhancement

Comments

@liamappelbe
Copy link
Contributor

filter_test.dart is actually an integration test, not a unit test. And it's essentially doing the same thing as integration_test.dart. The only difference, the reason it's separate, is that it applies config filters to the generated bindings.

It would be cleaner to make the filter tests just ordinary integration tests, but have a way in integration_test.dart of customizing the config per-test. Maybe something as simple as a hard coded map declared in integration_test.dart from test name to a list of different configs to apply.

@liamappelbe liamappelbe added type-infra A repository infrastructure change or enhancement package:swift2objc labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:swift2objc type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant