From 70521d794a41feb1f0f44cab08329b634eb77c20 Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 23 Sep 2024 22:49:21 +0200 Subject: [PATCH] Update health.dart (#298) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/dart-lang/tools/pull/587#discussion_r1759557904 --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
--- pkgs/corpus/lib/api.dart | 2 ++ pkgs/firehose/CHANGELOG.md | 4 ++++ pkgs/firehose/lib/src/health/health.dart | 1 + pkgs/firehose/pubspec.yaml | 2 +- 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/pkgs/corpus/lib/api.dart b/pkgs/corpus/lib/api.dart index 258d49fd..333696dc 100644 --- a/pkgs/corpus/lib/api.dart +++ b/pkgs/corpus/lib/api.dart @@ -180,6 +180,8 @@ class ApiUseCollector extends RecursiveAstVisitor implements SurveyorVisitor { return; } + //TODO: fix as soon as enclosingElement3 is on Dart stable + // ignore: deprecated_member_use var enclosingElement = element.enclosingElement!; if (enclosingElement.kind == ElementKind.CLASS) { diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md index 1ded817f..fa424963 100644 --- a/pkgs/firehose/CHANGELOG.md +++ b/pkgs/firehose/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.9.3 + +- Do not check Dart SDK in PR Health breaking check. + ## 0.9.2 - Improve formatting of the github workflow summary comments so they use less diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart index 12e1d1f7..042abd5a 100644 --- a/pkgs/firehose/lib/src/health/health.dart +++ b/pkgs/firehose/lib/src/health/health.dart @@ -166,6 +166,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati ...['pub', 'global', 'run'], 'dart_apitool:main', 'diff', + '--no-check-sdk-version', ...['--old', baseRelativePath], ...['--new', relativePath], ...['--report-format', 'json'], diff --git a/pkgs/firehose/pubspec.yaml b/pkgs/firehose/pubspec.yaml index 73403073..2b83244f 100644 --- a/pkgs/firehose/pubspec.yaml +++ b/pkgs/firehose/pubspec.yaml @@ -1,6 +1,6 @@ name: firehose description: A tool to automate publishing of Pub packages from GitHub actions. -version: 0.9.2 +version: 0.9.3 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose environment: