Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests dealing with enhanced parts are welcome now! #2825

Open
eernstg opened this issue Aug 20, 2024 · 1 comment
Open

Tests dealing with enhanced parts are welcome now! #2825

eernstg opened this issue Aug 20, 2024 · 1 comment
Assignees
@sgrekhov
Labels
area-test status-blocked Blocked from making progress by another (referenced) issue

Comments

@eernstg
Copy link
Member

eernstg commented Aug 20, 2024

Here is the specification: https://github.com/dart-lang/language/blob/main/working/augmentation-libraries/parts_with_imports.md.
@sgrekhov sgrekhov self-assigned this Aug 20, 2024
@sgrekhov sgrekhov mentioned this issue Aug 30, 2024
Open
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 2, 2024
@sgrekhov
dart-lang#2825. Add enhanced parts tests for top-level declarations a…
5c9cd4d 
…nd ownership
eernstg pushed a commit that referenced this issue Sep 2, 2024
@sgrekhov
#2825. Add enhanced parts tests for top-level declarations and owners…
36ad405 
…hip (#2842)

Add enhanced parts tests for top-level declarations and ownership. Note that a `part of` directive followed by a `part` directive is currently a syntax error. This will be corrected.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 3, 2024
@sgrekhov
dart-lang#2825. Add import inheritance and grammar tests
8a6e7e7
eernstg pushed a commit that referenced this issue Sep 3, 2024
@sgrekhov
#2825. Add import inheritance and grammar tests (#2843)
86b355a 
Add import inheritance and grammar tests. Note that some tests have a syntax error according to the implemented syntax because it doesn't allow part files to have imports.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 4, 2024
@sgrekhov
dart-lang#2825. Add scope tests. Part 1.
ce2fa29
eernstg pushed a commit that referenced this issue Sep 5, 2024
@sgrekhov
#2825. Add scope tests. Part 1. (#2845)
b469fea 
Add scope tests. Part 1. Note that import clauses in a part file are currently a syntax error, but will be supported.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 5, 2024
@sgrekhov
dart-lang#2825. Add scope tests. Part 2.
9a3b1eb
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 9, 2024
@sgrekhov
dart-lang#2825. Add scope tests. Part 1. (dart-lang#2845)
cae4360 
Add scope tests. Part 1. Note that import clauses in a part file are currently a syntax error, but will be supported.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 9, 2024
@sgrekhov
dart-lang#2825. Add scope tests. Part 3.
8e9beda
eernstg pushed a commit that referenced this issue Sep 9, 2024
@sgrekhov
#2825. Add scope tests. Part 2. (#2847)
e4193ef 
Add scope tests. Part 2
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 10, 2024
@sgrekhov
dart-lang#2825. Add export directive tests.
4b9484e
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 10, 2024
@sgrekhov
dart-lang#2825. Add tests for "Terminology" chapter of the spec.
6aebca3
eernstg pushed a commit that referenced this issue Sep 10, 2024
@sgrekhov
#2825. Add export directive tests. (#2854)
f79b9c1 
Add export directive tests
eernstg pushed a commit that referenced this issue Sep 10, 2024
@sgrekhov
#2825. Add tests for "Terminology" chapter of the spec. (#2855)
3e4822f
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 10, 2024
@sgrekhov
[co19] Roll co19 to a572236bc7d760dc986fd34abe6d0b8ae56254d7
ab23d7a 
2024-09-10 [email protected] Fixes dart-lang/co19#2852. Fix the new roll failures (dart-lang/co19#2853)
2024-09-09 [email protected] dart-lang/co19#2825. Add scope tests. Part 2. (dart-lang/co19#2847)
2024-09-09 [email protected] Fixes dart-lang/co19#2849. Fix new roll failures (dart-lang/co19#2850)
2024-09-09 [email protected] dart-lang/co19#2559. Replace augmentation libraries by parts (dart-lang/co19#2848)
2024-09-05 [email protected] dart-lang/co19#2825. Add scope tests. Part 1. (dart-lang/co19#2845)
2024-09-04 [email protected] dart-lang/co19#2398. Update TouchEvent tests to not fail on platforms where it is not defined (dart-lang/co19#2844)
2024-09-03 [email protected] dart-lang/co19#2825. Add import inheritance and grammar tests (dart-lang/co19#2843)
2024-09-02 [email protected] dart-lang/co19#2559. Add augmenting members tests. Part 2 (dart-lang/co19#2799)
2024-09-02 [email protected] dart-lang/co19#2825. Add enhanced parts tests for top-level declarations and ownership (dart-lang/co19#2842)
2024-09-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.2.1 to 4.2.2 in the github-actions group (dart-lang/co19#2841)
2024-08-30 [email protected] dart-lang/co19#2559. Add extension types to augmenting types tests (dart-lang/co19#2839)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I26f83579708b877918b5a0a904f8172aa1cf4724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384480
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
eernstg pushed a commit that referenced this issue Sep 11, 2024
@sgrekhov
#2825. Add scope tests. Part 3. (#2851)
c9cb693 
Add scope tests. Part 3.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 12, 2024
@sgrekhov
dart-lang#2825. Add tests for declarations in different branches of a…
517deb0 
… parts tree
eernstg pushed a commit that referenced this issue Sep 12, 2024
@sgrekhov
#2825. Add tests for declarations in different branches of a parts tr…
a339bd5 
…ee (#2870)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 12, 2024
@sgrekhov
dart-lang#2825. Update existing tests for Parts
fa3236c
eernstg pushed a commit that referenced this issue Sep 13, 2024
@sgrekhov
#2825. Update existing tests for Parts (#2871)
c6abd49 
Update existing tests for Parts
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 13, 2024
@sgrekhov @athomas
[co19] Roll co19 to baa1dd9ca815d468720d9f456e7f7498845222dc
a15be7c 
2024-09-13 [email protected] Fixes dart-lang/co19#2872. Fix runtime error in shared_case_scope_A02_t02.dart (dart-lang/co19#2876)
2024-09-13 [email protected] Fixes dart-lang/co19#2874. Fix typo in scope_A07_t01_part1.dart (dart-lang/co19#2875)
2024-09-13 [email protected] Fixes dart-lang/co19#2872. Fix `unreachable_switch_case` warning in shared_case_scope_A02_t02.dart (dart-lang/co19#2873)
2024-09-13 [email protected] dart-lang/co19#2825. Update existing tests for Parts (dart-lang/co19#2871)
2024-09-12 [email protected] dart-lang/co19#2825. Add tests for declarations in different branches of a parts tree (dart-lang/co19#2870)
2024-09-11 [email protected] dart-lang/co19#2868. Add extension methods accessibility tests. Part 1. (dart-lang/co19#2869)
2024-09-11 [email protected] Fixes dart-lang/co19#2856. Remove `unreachable_switch_default` warning (dart-lang/co19#2867)
2024-09-11 [email protected] Fixes dart-lang/co19#2861. Hide public extension methods if an import is deferred (dart-lang/co19#2866)
2024-09-11 [email protected] dart-lang/co19#2825. Add scope tests. Part 3. (dart-lang/co19#2851)
2024-09-11 [email protected] Fixes dart-lang/co19#2860. Remove accidental code from scope_A04_t01_part2.dart (dart-lang/co19#2865)
2024-09-11 [email protected] Fixes dart-lang/co19#2859. Hide public extension methods if an import is deferred (dart-lang/co19#2864)
2024-09-11 [email protected] Fixes dart-lang/co19#2858. Fix syntax error in scope_A03_t02_part1.dart (dart-lang/co19#2863)
2024-09-11 [email protected] Fixes dart-lang/co19#2857. Fix names conflict in scope_A02_t03_part2.dart (dart-lang/co19#2862)
2024-09-10 [email protected] dart-lang/co19#2825. Add tests for "Terminology" chapter of the spec. (dart-lang/co19#2855)
2024-09-10 [email protected] dart-lang/co19#2825. Add export directive tests. (dart-lang/co19#2854)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Idcee5a49ca69914516d1a331dab3d2b525a4b4b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/385282
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 16, 2024
@sgrekhov
dart-lang#2825. Add more grammar tests
ee670c8
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 17, 2024
@sgrekhov
dart-lang#2825. Add more grammar and terminology tests
35329b0
eernstg pushed a commit that referenced this issue Sep 24, 2024
@sgrekhov
#2825. Add more grammar tests (#2882)
eb7af0a 
Add more grammar tests
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 27, 2024
@sgrekhov
[co19] Roll co19 to 8d0c6ae63cdb788e121dace91c338c4453d22010
8076595 
2024-09-26 [email protected] dart-lang/co19#2846. Add syntax and whitespaces tests (dart-lang/co19#2896)
2024-09-26 [email protected] Fixes dart-lang/co19#2892. Change expected errors positions. (dart-lang/co19#2894)
2024-09-26 [email protected] Fixes dart-lang/co19#2893. In case of ambiguous export don't expect an error on the first export (dart-lang/co19#2895)
2024-09-26 [email protected] dart-lang/co19#2846. Add static semantics tests for unquoted imports (dart-lang/co19#2891)
2024-09-25 [email protected] dart-lang/co19#2846. Add unquoted imports tests for path separator (dart-lang/co19#2889)
2024-09-25 [email protected] dart-lang/co19#2846. Add unquoted imports tests for parts (dart-lang/co19#2890)
2024-09-24 [email protected] dart-lang/co19#2559. Update `defining_augmentation_*` tests (dart-lang/co19#2884)
2024-09-24 [email protected] dart-lang/co19#2825. Add more grammar tests (dart-lang/co19#2882)
2024-09-24 [email protected] Fixes dart-lang/co19#2878. Use pid for unique temp name (dart-lang/co19#2883)
2024-09-24 [email protected] Fixes dart-lang/co19#2877. Catch and ignore exceptions during temp file deletion (dart-lang/co19#2881)
2024-09-24 [email protected] Fixes dart-lang/co19#2879. Fix racy code in length_A01_t01.dart (dart-lang/co19#2880)
2024-09-23 [email protected] dart-lang/co19#2846. Add unquoted imports tests for keywords (dart-lang/co19#2886)
2024-09-23 [email protected] Fixes dart-lang/co19#2887. Fix border type in static_analysis_extension_types_A08_t11.dart (dart-lang/co19#2888)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ibf63f6246db950981a0ee445764f9625bb69a9f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387161
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
eernstg pushed a commit that referenced this issue Sep 27, 2024
@sgrekhov
#2825. Add more grammar and terminology tests (#2885)
7f3439d
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 4, 2024
@sgrekhov
[co19] Roll co19 to 3af31b33ccaf1b56002dbd3df989f6a97b321ae9
6d5aa79 
2024-10-04 [email protected] Fixes dart-lang/co19#2919. Fix new roll failures (dart-lang/co19#2920)
2024-10-03 [email protected] dart-lang/co19#2915. Add missing extension in syntax_A03_t01.dart (dart-lang/co19#2918)
2024-10-03 [email protected] Fixes dart-lang/co19#2915. Fix errors and typos in some null-aware elements tests (dart-lang/co19#2917)
2024-10-03 [email protected] Fixes dart-lang/co19#2906. Add digit separators 'parse' tests (dart-lang/co19#2916)
2024-10-03 [email protected] Fixes dart-lang/co19#2907. Update expected errors positions in grammar_A03_t01.dart (dart-lang/co19#2914)
2024-10-02 [email protected] dart-lang/co19#2906. Add digit separators tests (dart-lang/co19#2910)
2024-10-02 [email protected] dart-lang/co19#2907. Revert wrong change in grammar_A04_t01_part1.dart (dart-lang/co19#2913)
2024-10-02 [email protected] Fixes dart-lang/co19#2907. Update expected errors positions in grammar_A04_t01_part1.dart (dart-lang/co19#2912)
2024-10-02 [email protected] Fixes dart-lang/co19#2909. Fix extension applicability tests according to the updated spec (dart-lang/co19#2911)
2024-10-01 49699333+dependabot[bot]@users.noreply.github.com Bump the github-actions group with 2 updates (dart-lang/co19#2908)
2024-10-01 [email protected] dart-lang/co19#2559. Add tests for adding body to static members (dart-lang/co19#2905)
2024-09-30 [email protected] Fixes dart-lang/co19#2902. Add tests for an extension applicability (dart-lang/co19#2903)
2024-09-30 [email protected] Fixes dart-lang/co19#2901. Update expected errors for analyzer and CFE (dart-lang/co19#2904)
2024-09-27 [email protected] dart-lang/co19#2559. Fix typo in augmenting_enum_values_A05_t05.dart (dart-lang/co19#2900)
2024-09-27 [email protected] dart-lang/co19#2559. Add test that `EnumName` extension is not augmentable (dart-lang/co19#2899)
2024-09-27 [email protected] dart-lang/co19#2559. Add more tests for augmenting enum members and values. (dart-lang/co19#2897)
2024-09-27 [email protected] dart-lang/co19#2825. Add more grammar and terminology tests (dart-lang/co19#2885)
2024-09-27 [email protected] dart-lang/co19#2559. Fix accidental syntax errors (dart-lang/co19#2898)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Id70baf6e0f6a6ea62eb0b507bffc3c1fb39e71ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388007
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 7, 2024
@sgrekhov
dart-lang#2825. Fix dotted.library.name syntax in part of directive
e7fd9a9
eernstg pushed a commit that referenced this issue Oct 7, 2024
@sgrekhov
#2825. Fix dotted.library.name syntax in part of directive (#2922)
1d64f78 
Fix dotted.library.name syntax in `part of` directive
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 11, 2024
@sgrekhov
[co19] Roll co19 to dd66678fea1d11bc6295a688ed5f8e726034f762
9541425 
2024-10-10 [email protected] dart-lang/co19#2925. Add comment explaining why the syntax error is not reported in grammar_A05_t01_lib.dart (dart-lang/co19#2931)
2024-10-10 [email protected] Fixes dart-lang/co19#2925. Fix expected errors positions in grammar_A05_t01_lib.dart (dart-lang/co19#2929)
2024-10-09 [email protected] dart-lang/co19#2923. More tests for import and export library with the same URI. (dart-lang/co19#2928)
2024-10-09 [email protected] Fixes dart-lang/co19#2926. Remove unnecessary error expectation from grammar_A04_t01.dart (dart-lang/co19#2927)
2024-10-08 [email protected] dart-lang/co19#2923. Add tests for import/exports with the same URI (dart-lang/co19#2924)
2024-10-07 [email protected] dart-lang/co19#2825. Fix dotted.library.name syntax in `part of` directive (dart-lang/co19#2922)
2024-10-04 [email protected] dart-lang/co19#2559. Add augmenting enum values test. (dart-lang/co19#2921)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I81902e4e4eac8a0b0ffd3f20d957aa9bfcc2cdc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389700
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov added the status-blocked Blocked from making progress by another (referenced) issue label Oct 28, 2024
@sgrekhov
Copy link
Contributor

Waiting for dart-lang/language#4081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
area-test status-blocked Blocked from making progress by another (referenced) issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg