Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

export fbad_request function #86

Open
braunm opened this issue Mar 23, 2018 · 1 comment
Open

export fbad_request function #86

braunm opened this issue Mar 23, 2018 · 1 comment

Comments

@braunm
Copy link

braunm commented Mar 23, 2018

I think it would be useful for fbad_request() to be exported. This will aid in debugging, and offer some flexibility in using endpoints of the API that are not supported by the package (e.g., ad_studies).

It's one line of code: adding an @export statement before the function in fb_init.R, and using document() to update the NAMESPACE. With appropriate permissions, I can push a new branch and then make a pull request.

Thanks.

@daroczig
Copy link
Owner

I was considering this previously, but I think it's better to keep it private -- those devs who want to debug stuff or want to use not-supported API endpoints definitely know about :::, so although it would be a bit convenient for them, but would also cause more confusion for the less advanced users.

I will keep this ticket open, though, and depending on further feedback I'm open to changing my past decision :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants