Skip to content

Latest commit

 

History

History
417 lines (296 loc) · 14.9 KB

README.md

File metadata and controls

417 lines (296 loc) · 14.9 KB
Raw

Btrfs-progs tests

A testsuite covering functionality of btrfs-progs, ie. the checker, image, mkfs and similar tools. There are no additional requirements on kernel features (other than CONFIG_BTRFS_FS built-in or module), the tests build on top of the core functionality like snapshots and device management. In some cases optional features are turned on by mkfs and the filesystem image could be mounted, such tests might fail if there's lack of support.

Quick start

Run the tests from the top directory:

$ make test
$ make test-fsck
$ make test-convert

or selectively from the tests/ directory:

$ ./fsck-tests.sh
$ ./misc-tests.sh

The verbose output of the tests is logged into a file named after the test category, eg. fsck-tests-results.txt.

Selective testing

The tests are prefixed by a number for ordering and uniqueness. To run a particular test use:

$ make TEST=MASK test

where MASK is a glob expression that will execute only tests that match the MASK. Here the test number comes handy:

$ make TEST=001\* test-fsck      # in tests/
$ TEST=001\* ./fsck-tests.sh     # in the top directory

will run the first test in fsck-tests subdirectory. If the test directories follow a good naming scheme, it's possible to select a subset eg. like the convert tests for ext[234] filesystems using mask 'TEST='ext[234]'.

Test directory structure

tests/fsck-tests/

  • tests targeted at bugs that are fixable by fsck, the test directory can contain images that will get fixed, or a custom script ./test.sh that will be run if present

tests/convert-tests/

  • coverage tests of ext2/3/4 or reiserfs and btrfs-convert options

tests/fuzz-tests/

  • collection of fuzzed or crafted images
  • tests that are supposed to run various utilities on the images and not crash

tests/cli-tests/

  • tests for command line interface, option coverage, weird option combinations that should not work
  • not necessary to do any functional testing, could be rather lightweight
  • functional tests should go to other test directories
  • the driver script will only execute ./test.sh in the test directory

tests/misc-tests/

  • anything that does not fit to the above, the test driver script will only execute ./test.sh in the test directory

tests/common, tests/common.convert

  • scripts with shell helpers, separated by functionality

tests/test.img

  • default testing image, available as TEST_DEV variable, the file is never deleted by the scripts but truncated to 0 bytes, so it keeps it's permissions. It's eg. possible to host it on NFS, make it chmod a+w for root.

Other tuning, environment variables

Instrumentation

It's possible to wrap the tested commands to utilities that might do more checking or catch failures at runtime. This can be done by setting the INSTRUMENT environment variable:

make INSTRUMENT=valgrind test-fuzz     # in the top directory
INSTRUMENT=valgrind ./fuzz-tests.sh    # in tests/

The variable is prepended to the command unquoted, all sorts of shell tricks are possible.

Note: instrumentation is not applied to privileged commands (anything that uses the root helper), with exception of all commands built from git that will be instrumented even if run with the sudo helper.

run_check $SUDO_HELPER mount /dev/sdx /mnt           # no instrumentation
run_check $SUDO_HELPER "$TOP/btrfs" check /dev/sdx   # with instrumentation

Instrumented commands: btrfs, btrfs-image, btrfs-convert, btrfs-tune, mkfs.btrfs, btrfs-select-super, btrfs-find-root, btrfs-corrupt-block.

As mentioned above, instrumentation tools are like valgrind or potentially gdb with some init script that will let the commands run until an exception occurs, possibly allowing to continue interactively debugging.

Verbosity, test tuning

  • TEST_LOG=tty -- setting the variable will print all commands executed by some of the wrappers (run_check etc), other commands are not printed to the terminal (but the full output is in the log)

  • TEST_LOG=dump -- dump the entire testing log when a test fails

  • TEST_FLAVOR -- run binaries of specified flavor, which is dynamic build by default, or static using all the build binaries with .static suffix

  • TEST_ENABLE_OVERRIDE -- defined either as make arguments or via tests/common.local to enable additional arguments to some commands, using the variable(s) below (default: false, enable by setting to 'true')

  • TEST_ARGS_CHECK -- user-defined arguments to btrfs check, before the test-specific arguments

  • TEST_ARGS_MKFS -- user-defined arguments to mkfs.btrfs, before the test-specific arguments

  • TEST_ARGS_CONVERT -- user-defined arguments to btrfs-convert, before the test-specific arguments

Multiple values can be separated by ,.

For example, running all fsck tests with the --mode=lowmem option can be done as

$ make TEST_ENABLE_OVERRIDE=true TEST_ARGS_CHECK=--mode=lowmem test-check

Specifically, fsck-tests that are known to be able to repair images in the lowmem mode shoulde be marked using a file .lowmem_repairable in the test directory. Then the fsck-tests with the 'mode=lowmem' will continue when image repair is requested.

Permissions

Some commands require root privileges (to mount/umount, access loop devices or call privileged ioctls). It is assumed that sudo will work in some way (no password, password asked and cached). Note that instrumentation is not applied in this case, for safety reasons or because the tools refuse to run under root. You need to modify the test script instead.

Cleanup

The tests are supposed to cleanup after themselves if they pass. In case of failure, the rest of the tests are skipped and intermediate files, mounts and loop devices are kept. This should help to investigate the test failure but at least the mounts and loop devices need to be cleaned before the next run.

This is partially done by the script clean-tests.sh, you may want to check the loop devices as they are managed on a per-test basis, see the output of command losetup and eventually delete all existing loop devices with losetup -D.

Prototyping tests, quick tests

There's a script test-console.sh that will run shell commands in a loop and logs the output with the testing environment set up. It sources the common helper scripts so the shell functions are available.

Runtime dependencies

The tests use some common system utilities like find, rm, dd. Additionally, specific tests need the following packages installed: acl, attr, e2fsprogs, reiserfsprogs.

New test

  1. Pick the category for the new test or fallback to misc-tests if not sure. For an easy start copy an existing test.sh script from some test that might be close to the purpose of your new test. The environment setup includes the common scripts and/or prepares the test devices. Other scripts contain examples how to do mkfs, mount, unmount, check, loop device management etc.

  2. Use the highest unused number in the sequence, write a short descriptive title and join by dashes -. This will become the directory name, eg. 012-subvolume-sync-must-wait.

  3. Write a short description of the bug and how it's tested to the comment at the beginning of test.sh. You don't need to add the file to git yet. Don't forget to make the file executable, otherwise it's not going to be executed by the infrastructure.

  4. Write the test commands, comment anything that's not obvious.

  5. Test your test. Use the TEST variable to jump right to your test:

$ make TEST=012\* tests-misc           # from top directory
$ TEST=012\* ./misc-tests.sh           # from tests/

  1. The commit changelog should reference a commit that either introduced or fixed the bug (or both). Subject line of the shall mention the name of the new directory for ease of search, eg. btrfs-progs: tests: add 012-subvolume-sync-must-wait

  2. A commit that fixes a bug should be applied before the test that verifies the fix. This is to keep the git history bisectable.

Test images

Most tests should be able to create the test images from scratch, using regular commands and file operation. The commands also document the testcase and use the test code and kernel of the environment.

In other cases, a pre-created image may be the right way if the above does not work (eg. comparing output, requesting an exact layout or some intermediate state that would be hard to achieve otherwise).

  • images that don't need data and valid checksums can be created by btrfs-image, the image can be compressed by the tool itself (file extension .img) or compressed externally (recognized is .img.xz)

  • raw images that are binary dump of an existing image, created eg. from a sparse file (.raw or .raw.xz)

Use xz --best and try to get the smallest size as the file is stored in git.

Crafted/fuzzed images

Images that are created by fuzzing or specially crafted to trigger some error conditions should be added to the directory fuzz-tests/images, accompanied by a textual description of the source (bugzilla, mail), the reporter, brief description of the problem or the stack trace.

If you have a fix for the problem, please submit it prior to the test image, so the fuzz tests always succeed when run on random checked out. This helps bisectability.

Exported testsuite

The tests are typically run from git on binaries built from the git sources. It is possible to extract only the testsuite files and run it independently. Use

$ make testsuite

This will gather scripts and generate tests/btrfs-progs-tests.tar.gz. The files inside the tar are in the top level directory, make sure you extract the contents to an empty directory. From there you can start the tests as described above (the non-make variant).

By default the binaries found in $PATH are used, this will normally mean the system binaries. You can also override the $TOP shell variable and this path will be used as prefix for all btrfs binaries inside the tests.

There are some utilities that are not distributed but are necessary for the tests. They are in the top level directory of the testsuite and their path cannot be set.

The tests assume write access to their directories.

Coding style, best practices

do

  • quote all variables by default, any path, even the TOP could need that, and we use it everywhere
    • even if the variable is safe, use quotes for consistency and to ease reading the code
    • there are exceptions:
      • $SUDO_HELPER as it might be intentionally unset
  • use #!/bin/bash explicitly
  • check for all external dependencies (check_prereq_global)
  • check for internal dependencies (check_prereq), though the basic set is always built when the tests are started through make
  • use functions instead of repeating code
    • generic helpers could be factored to the common script
  • cleanup files an intermediate state (mount, loop devices, device mapper devices) a after successful test
  • use common helpers and variables where possible

do not

  • pull external dependencies if we can find a way to replace them: example is xfs_io that's conveniently used in fstests but we'd require xfsprogs, so use dd instead
  • throw away (redirect to /dev/null) output of commands unless it's justified (ie. really too much text, unnecessary slowdown) -- the test output log is regenerated all the time and we need to be able to analyze test failures or just observe how the tests progress
  • cleanup after failed test -- the testsuite stops on first failure and the developer can eg. access the environment that the test created and do further debugging
    • this might change in the future so the tests cover as much as possible, but this would require to enhance all tests with a cleanup phase

Simple test template

The file tests/common provides shell functions to ease writing common things like setting up the test devices, making or mounting a filesystem, setting up loop devices.

#!/bin/bash
# Simple test to create a new filesystem and test that it can be mounted

source "$TEST_TOP/common"

setup_root_helper
prepare_test_dev

run_check_mkfs_test_dev
run_check_mount_test_dev
run_check $SUDO_HELPER dd if=/dev/zero of="$TEST_MNT"/file bs=1M count=1
run_check_umount_test_dev

Each test should be briefly described, source the helpers like run_check. The root helper is the sudo wrapper that can be used as $SUDO_HELPER variable. The implicit variables for testing device is $TEST_DEV mounted at $TEST_MNT. The mkfs and mount helpers take arguments that are then injected into the right place in the respective command.

Besides the setup and cleanup code, the main test in this example is dd that writes 1MiB to a file in the newly created filesystem.

Multiple device test template

Tests that need more devices can utilize the loop devices, an example test of the above:

# Create a new multi-device filesystem and test that it can be mounted

source "$TEST_TOP/common"

setup_root_helper
setup_loopdevs 4
prepare_loopdevs
TEST_DEV=${loopdevs[1]}

run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f -d raid1 -m raid1 "${loopdevs[@]}"
run_check_mount_test_dev
run_check $SUDO_HELPER dd if=/dev/zero of="$TEST_MNT"/file bs=1M count=1
run_check_umount_test_dev

cleanup_loopdevs

A 'btrfs check' test template

The easiest way to test an image is to put it to the test directory, without the test.sh script. All images found are simply processed by the shell function check_image with default parameters.

Any tweaks to the 'check' subcommand can be done by redefining the function:

source "$TEST_TOP/common"

check_image() {
	run_check "$TOP/btrfs" check --readonly "$1"
}

check_all_images

The images can be stored in various formats, see section 'Test images'.

Misc hints

There are several helpers in tests/common, it's recommended to read through that file or other tests to get the idea how easy writing a test really is.

  • result
    • _fail - a failure condition has been found
    • _not_run - some prerequisite condition is not met, eg. missing kernel functionality
  • messages
    • _log - message printed to the result file (eg. tests/mkfs-tests-results.txt), and not printed to the terminal
    • _log_stdout - dtto but it is printed to the terminal
  • execution helpers
    • run_check - should be used for basically all commands, the command and arguments are stored to the results log for debugging and the return value is checked so there are no silent failures even for the "unimportant" commands
    • run_check_stdout - like the above but the output can be processed further, eg. filtering out some data or looking for some specific string
    • run_mayfail - the command is allowed to fail in a non-fatal way (eg. no segfault), there's also the run_mayfail_stdout variant
    • run_mustfail - expected failure, note that the first argument is mandatory message describing unexpected pass condition