Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test select node versions #494

Open
shubham1172 opened this issue May 26, 2023 · 4 comments
Open

Document and test select node versions #494

shubham1172 opened this issue May 26, 2023 · 4 comments
Labels
area/tests Test cases related documentation Improvements or additions to documentation pinned
Milestone

Comments

@shubham1172
Copy link
Member

Describe the proposal

We do not have officially supported versions today and our tests always run on a single node version (16.x.x for now).

image

With this proposal, we should maintain a list of node versions that we officially support and test them.

@shubham1172 shubham1172 added documentation Improvements or additions to documentation area/tests Test cases related labels May 26, 2023
@shubham1172
Copy link
Member Author

Also explore if an engines entry should be added - https://docs.npmjs.com/cli/v9/configuring-npm/package-json?v=true#engines

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Jul 25, 2023
@dapr-bot
Copy link
Collaborator

dapr-bot commented Aug 1, 2023

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@dapr-bot dapr-bot closed this as completed Aug 1, 2023
@shubham1172 shubham1172 reopened this Aug 1, 2023
@shubham1172 shubham1172 added pinned and removed stale labels Aug 1, 2023
@shubham1172 shubham1172 pinned this issue May 5, 2024
@shubham1172
Copy link
Member Author

Node 16 has reached EOL on Sep 2023, we should move to Node 18+ https://nodejs.org/en/blog/announcements/nodejs16-eol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Test cases related documentation Improvements or additions to documentation pinned
Projects
None yet
Development

No branches or pull requests

3 participants