Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perfsprint linter errors #1374

Open
mukundansundar opened this issue Jan 16, 2024 · 3 comments
Open

Fix perfsprint linter errors #1374

mukundansundar opened this issue Jan 16, 2024 · 3 comments
Assignees
@KentHsu
Labels
good first issue Good for newcomers kind/proposal A new proposal to be considered
Milestone
v1.15

Comments

@mukundansundar
Copy link
Collaborator

Describe the proposal

For now //nolint: perfsprint has been added in some files in CLI.

Make changes in CLI to convert the fmt.Sprintf("%d)...) into strconv.Itoa and handle associated errors as well.

Release Note

RELEASE NOTE:
@mukundansundar mukundansundar added good first issue Good for newcomers kind/proposal A new proposal to be considered labels Jan 16, 2024
@mukundansundar mukundansundar added this to the v1.14 milestone Jan 16, 2024
@mukundansundar mukundansundar mentioned this issue Jan 16, 2024
Merged
3 tasks
@sp6370
Copy link

sp6370 commented Jan 16, 2024

@mukundansundar I would like to pick this up.

@sp6370
Copy link

sp6370 commented Jan 16, 2024

/assign

@sp6370 sp6370 removed their assignment Jul 1, 2024
@KentHsu
Copy link

KentHsu commented Jul 24, 2024

/assign

@KentHsu KentHsu mentioned this issue Jul 24, 2024
Closed
3 tasks
@antontroshin antontroshin modified the milestones: v1.14, v1.15 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KentHsu KentHsu

Labels
good first issue Good for newcomers kind/proposal A new proposal to be considered
Projects
None yet
Milestone
v1.15
Development

Successfully merging a pull request may close this issue.

fix perfsprint linter error KentHsu/cli
4 participants
@KentHsu @antontroshin @sp6370 @mukundansundar