Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Candlelight Dinner Mod multi-use meals #31

Open
KaliKallixti opened this issue Jul 28, 2023 · 4 comments
Open

Incompatible with Candlelight Dinner Mod multi-use meals #31

KaliKallixti opened this issue Jul 28, 2023 · 4 comments

Comments

@KaliKallixti
Copy link

Eating the Lasagna meal from Candlelight Dinner - has four portions in one bowl - caused a ticking exception in Neruina

image

@dannydjdk
Copy link
Owner

Thanks for the report! Do you have a crash report and/or a link to the other mods contributing to the crash? Also, what is the reason you believe Nutritional Balance is the reason for this crash?
I am unable to troubleshoot this without more information or some way to reproduce the problem.

@KaliKallixti
Copy link
Author

Hi! I'm so sorry, I accidentally left out the crucial bit- eating the Lasagna meal from Candlelight Dinner specifically from the Nutritional Balance lunchbox causes the kick due to a ticking exception. I only assume it's because it's a multi-use meal, but it's definitely every time on my end. I don't have a crash report because it's not crashing me, it's just kicking me from the server (in this case the Cottage Witch Recast modpack public server.)

@dannydjdk
Copy link
Owner

Got it! I was able to reproduce the crash, so I can begin troubleshooting.
I was a bit confused, because the mod is actually called [Let's Do] Candlelight, and I could find a mod called Candlelight Dinner.

@dannydjdk
Copy link
Owner

Unfortunately, this is not something that can be fixed on my end, and this will likely break with any lunchbox from any mod.

The problem is that Candlelight is attempting to access the inventory slot directly within the user's inventory:
https://github.com/satisfyu/Candlelight-Dinner/blob/2c53ea65b934d393875c1b9e5a6d56edc74f0b34/common/src/main/java/satisfyu/candlelight/food/EffectFoodBlockItem.java#L57C44-L57C44

That function returns -1, because, of course, the item is not in a player's inventory slot. So this line then causes the crash: https://github.com/satisfyu/Candlelight-Dinner/blob/2c53ea65b934d393875c1b9e5a6d56edc74f0b34/common/src/main/java/satisfyu/candlelight/food/EffectFoodBlockItem.java#L63

Unfortunately, they don't have an issue tracker on GitHub, so I can't link this issue to an issue there. You have to go to their Discord to report it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants