Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] A lunchbox like Spice of Life has #28

Open
katubug opened this issue Jun 25, 2023 · 4 comments
Open

[Request] A lunchbox like Spice of Life has #28

katubug opened this issue Jun 25, 2023 · 4 comments
Assignees
@dannydjdk
Labels
enhancement New feature or request

Comments

@katubug
Copy link

katubug commented Jun 25, 2023

Hello! I'm a modpack dev and I'm looking to switch from Spice of Life to Nutritional Balance. Well, technically we have made the switch and in general I'm thrilled! Everyone seems to like the mod so far. However, one common thread from a significant number of users is that they miss the lunchboxes from Spice of Life.

I'm sure you're familiar, but just in case you're not, they function as an inventory which can only hold food. Holding the item and shift+right clicking allows you to open its inventory and put food items in. Holding the item and holding down right click allows you to "eat" the lunchbox, which consumes a food item from its inventory and gives the player the appropriate hunger/saturation/food diversity. Some versions have a "smart" lunchbox which prioritizes food which would best benefit the player (in terms of this mod, this would mean prioritizing foods that have nutrients which the player is lacking in).

I understand this would be quite the undertaking, but I feel it would be a really solid addition to the mod, and would certainly make a lot of my players very happy. Thank you very much for your time!
@katubug
Copy link
Author

katubug commented Jun 25, 2023

One of my mods linked me a comment where you mentioned you'd considered a lunchbox but would not want the smart-selection feature that SoL has. This would be totally fine with me. I think the scrolling to select a food item is perfectly good.

@dannydjdk
Copy link
Owner

Thanks for the suggestion! This is on my todo list, probably without the smart selection, but I am considering some interesting ways it might help you make the best selection.

@dannydjdk dannydjdk added the enhancement New feature or request label Jun 25, 2023
@dannydjdk dannydjdk self-assigned this Jun 25, 2023
dannydjdk referenced this issue Jun 28, 2023
@dannydjdk
Lunchbox!
f0101c6 
 - Inventory item to hold several stacks of food.
 - Can eat selected food item directly from lunch box.
TODO:
 - Lunchbox recipe
 - Item renderer showing active food
 - Show nutrient status in lunchbox GUI.
 - Shift-scroll with lunchbox item to change active food.
dannydjdk added a commit that referenced this issue Jul 1, 2023
@dannydjdk
- Lunchbox renderer showing active food
dc10fe0 
 - Show nutrient status in lunchbox GUI.
#28

TODO:
 - Lunchbox recipe
 - Fix dark rendering of active food item in inventory GUI.
dannydjdk added a commit that referenced this issue Jul 1, 2023
@dannydjdk
- Shift scroll lunchbox to toggle through active foods
0122058 
 - Lunchbox recipe
 - Added config to change number of inventory slots in lunchbox and changed various loops handling those inventory slots to use dynamic number of slots.
 - Added tooltip describing lunch box usage.
 - Fixed active food rendering dark in GUI by angling it up toward light (I guess) and stretching it
 - set eating particle
 - Refactored registration activities into their helper class.
#28
@dannydjdk
Copy link
Owner

Released as beta for 1.20. Back ports in progress.

@katubug
Copy link
Author

katubug commented Jul 2, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannydjdk dannydjdk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dannydjdk @katubug