From 519eab4ebffc8405e33411c51aba20eb57a2cf5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Thu, 15 Aug 2024 20:51:58 +0200 Subject: [PATCH 1/3] remove unneeded suppressions --- cppcheckpremium-suppressions | 2 -- 1 file changed, 2 deletions(-) diff --git a/cppcheckpremium-suppressions b/cppcheckpremium-suppressions index 2bbbe61e71c..c731b20f5ba 100644 --- a/cppcheckpremium-suppressions +++ b/cppcheckpremium-suppressions @@ -59,8 +59,6 @@ premium-misra-cpp-2023-6.8.3 premium-misra-cpp-2023-7.0.3 premium-misra-cpp-2023-8.2.5 premium-misra-cpp-2023-8.18.2 -premium-misra-cpp-2023-13.1.2 -premium-misra-cpp-2023-13.3.1 premium-misra-cpp-2023-21.6.2 # False positives: #13004 premium-misra-cpp-2023-8.2.7:lib/valueflow.cpp From 227f4bb11c50eda363fa0b66d811626a9642d76d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Thu, 15 Aug 2024 21:07:31 +0200 Subject: [PATCH 2/3] devdrop --- .github/workflows/cppcheck-premium.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cppcheck-premium.yml b/.github/workflows/cppcheck-premium.yml index 0afe6905305..5f5a97e0863 100644 --- a/.github/workflows/cppcheck-premium.yml +++ b/.github/workflows/cppcheck-premium.yml @@ -29,7 +29,7 @@ jobs: run: | premium_version=${{ inputs.premium_version }} if [ -z $premium_version ]; then - premium_version=devdrop-20240811 + premium_version=devdrop-20240815 wget https://files.cppchecksolutions.com/devdrop/cppcheckpremium-$premium_version-amd64.tar.gz -O cppcheckpremium.tar.gz else wget https://files.cppchecksolutions.com/$premium_version/ubuntu-22.04/cppcheckpremium-$premium_version-amd64.tar.gz -O cppcheckpremium.tar.gz From 6d27d8f8259ebf67bdc737719c8a9fc3ca01535b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Thu, 15 Aug 2024 22:10:18 +0200 Subject: [PATCH 3/3] suppressions --- cppcheckpremium-suppressions | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/cppcheckpremium-suppressions b/cppcheckpremium-suppressions index c731b20f5ba..07fce749a80 100644 --- a/cppcheckpremium-suppressions +++ b/cppcheckpremium-suppressions @@ -55,11 +55,7 @@ premium-cert-exp55-cpp # There are false positives premium-misra-cpp-2023-6.5.1:lib/symboldatabase.cpp premium-misra-cpp-2023-6.7.2 -premium-misra-cpp-2023-6.8.3 -premium-misra-cpp-2023-7.0.3 -premium-misra-cpp-2023-8.2.5 premium-misra-cpp-2023-8.18.2 -premium-misra-cpp-2023-21.6.2 # False positives: #13004 premium-misra-cpp-2023-8.2.7:lib/valueflow.cpp premium-misra-cpp-2023-8.2.7:lib/checkclass.cpp @@ -98,6 +94,9 @@ premium-misra-cpp-2023-6.5.2 # we use local static variables by intention premium-misra-cpp-2023-6.7.1 +# Could write good warnings but also has a warning about safe code +premium-misra-cpp-2023-6.8.3 + # FIXME enforce proper ref qualifications premium-misra-cpp-2023-6.8.4 @@ -110,6 +109,9 @@ premium-misra-cpp-2023-7.0.1 # we convert integer to bool by intention premium-misra-cpp-2023-7.0.2 +# Misra C++ is too pedantic about using character values +premium-misra-cpp-2023-7.0.3 + # signed integer expression in bitwise rhs by intention premium-misra-cpp-2023-7.0.4 @@ -245,6 +247,9 @@ premium-misra-cpp-2023-21.2.3 # Dynamic memory usage in std::string etc premium-misra-cpp-2023-21.6.1 +# We use new/delete by intention sometimes +premium-misra-cpp-2023-21.6.2 + # TODO use std::make_unique when we require C++14 premium-misra-cpp-2023-23.11.1